Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 294293002: Enable --high-dpi-support by default. (Note that this is a registry setting. Also, remove dead refe… (Closed)

Created:
6 years, 7 months ago by ananta
Modified:
6 years, 6 months ago
Reviewers:
cpu_(ooo_6.6-7.5), sky
CC:
chromium-reviews, piman+watch_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Enable --high-dpi-support by default. (Note that this is a registry setting. Also, remove dead references to HiDPI flag.). This patch is based on portions of girard's patch here https://codereview.chromium.org/232483005/ BUG=149881, 362245 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273211

Patch Set 1 #

Total comments: 2

Patch Set 2 : Reverted changes to plugin_browsertest.cc #

Patch Set 3 : Rebased to tip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -15 lines) Patch
M chrome/browser/chrome_browser_main_win.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/plugin_process_host.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M ui/gfx/switches.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/switches.cc View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M ui/gfx/win/dpi.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 22 (0 generated)
ananta
6 years, 7 months ago (2014-05-23 18:39:32 UTC) #1
sky
https://codereview.chromium.org/294293002/diff/1/content/browser/plugin_browsertest.cc File content/browser/plugin_browsertest.cc (right): https://codereview.chromium.org/294293002/diff/1/content/browser/plugin_browsertest.cc#newcode5 content/browser/plugin_browsertest.cc:5: #include "content/browser/plugin_process_host.h" Are these changes expected?
6 years, 7 months ago (2014-05-23 20:44:03 UTC) #2
ananta
https://codereview.chromium.org/294293002/diff/1/content/browser/plugin_browsertest.cc File content/browser/plugin_browsertest.cc (right): https://codereview.chromium.org/294293002/diff/1/content/browser/plugin_browsertest.cc#newcode5 content/browser/plugin_browsertest.cc:5: #include "content/browser/plugin_process_host.h" On 2014/05/23 20:44:03, sky wrote: > Are ...
6 years, 7 months ago (2014-05-23 21:16:29 UTC) #3
sky
LGTM
6 years, 7 months ago (2014-05-23 22:11:16 UTC) #4
ananta
The CQ bit was checked by ananta@chromium.org
6 years, 7 months ago (2014-05-27 21:34:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ananta@chromium.org/294293002/20001
6 years, 7 months ago (2014-05-27 21:36:15 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium ...
6 years, 7 months ago (2014-05-28 00:58:46 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-28 01:02:27 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/31508) linux_chromium_gn_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel/builds/10760)
6 years, 7 months ago (2014-05-28 01:02:28 UTC) #9
ananta
The CQ bit was checked by ananta@chromium.org
6 years, 7 months ago (2014-05-28 01:40:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ananta@chromium.org/294293002/40001
6 years, 7 months ago (2014-05-28 01:42:19 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 7 months ago (2014-05-28 05:19:35 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-28 06:25:31 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/157475)
6 years, 7 months ago (2014-05-28 06:25:32 UTC) #14
ananta
The CQ bit was checked by ananta@chromium.org
6 years, 7 months ago (2014-05-28 06:41:58 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ananta@chromium.org/294293002/40001
6 years, 7 months ago (2014-05-28 06:42:38 UTC) #16
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 7 months ago (2014-05-28 07:31:59 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-28 08:09:04 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/157488)
6 years, 7 months ago (2014-05-28 08:09:05 UTC) #19
ananta
The CQ bit was checked by ananta@chromium.org
6 years, 6 months ago (2014-05-28 11:11:54 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ananta@chromium.org/294293002/40001
6 years, 6 months ago (2014-05-28 11:12:47 UTC) #21
commit-bot: I haz the power
6 years, 6 months ago (2014-05-28 13:59:47 UTC) #22
Message was sent while issue was closed. 
Change committed as 273211

Powered by Google App Engine
This is Rietveld 408576698