Task Scheduler API migration: change BrowserThreadModelWorker to SequencedModelWorker

Task Scheduler API migration: change BrowserThreadModelWorker to SequencedModelWorker

BrowserThreads are being deprecated in favor of TaskScheduler API.
This change refactors BrowserThreadModelWorker preparing it to
run on a sequence rather than a browser thread.

Most of this change is a trivial renaming:
BrowserThreadModelWorker -> SequencedModelWorker
IsOnModelThread -> IsOnModelSequence

BUG=689520, 731903
Review-Url: https://codereview.chromium.org/2942773002
Cr-Commit-Position: refs/heads/master@{#480569}
Committed: https://chromium.googlesource.com/chromium/src/+/5c6a294f5b440b85ba9e9156d1f040e869a53b58

[stanisc, 2017-06-14 20:59:54]

Description was changed from

==========
Task Scheduler API migration: change BrowserThreadModelWorker to
SequenceModelWorker

BUG=667892,731903
==========

to

==========
Task Scheduler API migration: change BrowserThreadModelWorker to
SequenceModelWorker

BrowserThreads are being deprecated in favor of TaskScheduler API.
This change refactors BrowserThreadModelWorker preparing it to
run on a sequence rather than a browser thread.

Most of this change is a trivial renaming:
BrowserThreadModelWorker -> SequenceModelWorker
IsOnModelThread -> IsOnModelSequence

BUG=689520,731903
==========

[stanisc, 2017-06-14 21:00:53]

stanisc@chromium.org changed reviewers:
+ pavely@chromium.org

[stanisc, 2017-06-14 21:02:29]

stanisc@chromium.org changed reviewers:
+ skym@chromium.org
- pavely@chromium.org

[stanisc, 2017-06-14 21:12:10]

stanisc@chromium.org changed reviewers:
+ vasilii@chromium.org

[stanisc, 2017-06-14 21:13:30]

stanisc@chromium.org changed reviewers:
+ sdefresne@chromium.org
- vasilii@chromium.org

[stanisc, 2017-06-14 21:15:54]

stanisc@chromium.org changed reviewers:
+ vasilii@chromium.org

[stanisc, 2017-06-14 21:16:28]

The CQ bit was checked by stanisc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-14 21:16:43]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stanisc, 2017-06-14 22:39:32]

sdefresne@, please review components/history

vasilii@, please review components/password_manager

skym@, please review everything else

[stanisc, 2017-06-14 22:40:21]

Description was changed from

==========
Task Scheduler API migration: change BrowserThreadModelWorker to
SequenceModelWorker

BrowserThreads are being deprecated in favor of TaskScheduler API.
This change refactors BrowserThreadModelWorker preparing it to
run on a sequence rather than a browser thread.

Most of this change is a trivial renaming:
BrowserThreadModelWorker -> SequenceModelWorker
IsOnModelThread -> IsOnModelSequence

BUG=689520,731903
==========

to

==========
Task Scheduler API migration: change BrowserThreadModelWorker to
SequencedModelWorker

BrowserThreads are being deprecated in favor of TaskScheduler API.
This change refactors BrowserThreadModelWorker preparing it to
run on a sequence rather than a browser thread.

Most of this change is a trivial renaming:
BrowserThreadModelWorker -> SequencedModelWorker
IsOnModelThread -> IsOnModelSequence

BUG=689520,731903
==========

[commit-bot: I haz the power, 2017-06-14 23:19:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-14 23:19:15]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[sdefresne, 2017-06-15 13:22:56]

components/history/ & ios/ lgtm

[vasilii, 2017-06-16 09:28:20]

lgtm

components/password_manager/

[skym, 2017-06-16 17:26:53]

lgtm

https://codereview.chromium.org/2942773002/diff/1/components/sync/engine/mode...
File components/sync/engine/model_safe_worker.h (right):

https://codereview.chromium.org/2942773002/diff/1/components/sync/engine/mode...
components/sync/engine/model_safe_worker.h:79: // Schedules |work| on the
appropriate thread.
Should this be updated from "thread" to "sequence"?

https://codereview.chromium.org/2942773002/diff/1/components/sync/engine/pass...
File components/sync/engine/passive_model_worker.h (right):

https://codereview.chromium.org/2942773002/diff/1/components/sync/engine/pass...
components/sync/engine/passive_model_worker.h:14: // done on the same thread
DoWorkAndWaitUntilDone (i.e., the sync
update to sequence?

https://codereview.chromium.org/2942773002/diff/1/components/sync/engine/sequ...
File components/sync/engine/sequenced_model_worker_unittest.cc (right):

https://codereview.chromium.org/2942773002/diff/1/components/sync/engine/sequ...
components/sync/engine/sequenced_model_worker_unittest.cc:35: // Schedule DoWork
to be executed on the DB thread and have the test fail if
DB thread

https://codereview.chromium.org/2942773002/diff/1/components/sync/engine/sequ...
components/sync/engine/sequenced_model_worker_unittest.cc:45: // This is the
work that will be scheduled to be done on the DB thread.
DB thread

[stanisc, 2017-06-19 19:13:38]

The CQ bit was checked by stanisc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-19 19:13:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stanisc, 2017-06-19 19:14:05]

https://codereview.chromium.org/2942773002/diff/1/components/sync/engine/mode...
File components/sync/engine/model_safe_worker.h (right):

https://codereview.chromium.org/2942773002/diff/1/components/sync/engine/mode...
components/sync/engine/model_safe_worker.h:79: // Schedules |work| on the
appropriate thread.
On 2017/06/16 17:26:52, skym wrote:
> Should this be updated from "thread" to "sequence"?

Done.

https://codereview.chromium.org/2942773002/diff/1/components/sync/engine/pass...
File components/sync/engine/passive_model_worker.h (right):

https://codereview.chromium.org/2942773002/diff/1/components/sync/engine/pass...
components/sync/engine/passive_model_worker.h:14: // done on the same thread
DoWorkAndWaitUntilDone (i.e., the sync
On 2017/06/16 17:26:52, skym wrote:
> update to sequence?

Done.

https://codereview.chromium.org/2942773002/diff/1/components/sync/engine/sequ...
File components/sync/engine/sequenced_model_worker_unittest.cc (right):

https://codereview.chromium.org/2942773002/diff/1/components/sync/engine/sequ...
components/sync/engine/sequenced_model_worker_unittest.cc:35: // Schedule DoWork
to be executed on the DB thread and have the test fail if
On 2017/06/16 17:26:53, skym wrote:
> DB thread

Done.

https://codereview.chromium.org/2942773002/diff/1/components/sync/engine/sequ...
components/sync/engine/sequenced_model_worker_unittest.cc:45: // This is the
work that will be scheduled to be done on the DB thread.
On 2017/06/16 17:26:53, skym wrote:
> DB thread

Done.

[commit-bot: I haz the power, 2017-06-19 20:47:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-19 20:47:20]

Dry run: This issue passed the CQ dry run.

[stanisc, 2017-06-19 20:49:08]

The CQ bit was checked by stanisc@chromium.org

[stanisc, 2017-06-19 20:49:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
vasilii@chromium.org, skym@chromium.org, sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/2942773002/#ps20001
(title: "Updated more comments to reflect thread -> sequence migration.")

[commit-bot: I haz the power, 2017-06-19 20:49:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-19 20:56:58]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497905348131050,
"parent_rev": "69d6b4f2a3ddc4ff581714a1e31030c8dab17076", "commit_rev":
"5c6a294f5b440b85ba9e9156d1f040e869a53b58"}

[commit-bot: I haz the power, 2017-06-19 20:57:13]

Description was changed from

==========
Task Scheduler API migration: change BrowserThreadModelWorker to
SequencedModelWorker

BrowserThreads are being deprecated in favor of TaskScheduler API.
This change refactors BrowserThreadModelWorker preparing it to
run on a sequence rather than a browser thread.

Most of this change is a trivial renaming:
BrowserThreadModelWorker -> SequencedModelWorker
IsOnModelThread -> IsOnModelSequence

BUG=689520,731903
==========

to

==========
Task Scheduler API migration: change BrowserThreadModelWorker to
SequencedModelWorker

BrowserThreads are being deprecated in favor of TaskScheduler API.
This change refactors BrowserThreadModelWorker preparing it to
run on a sequence rather than a browser thread.

Most of this change is a trivial renaming:
BrowserThreadModelWorker -> SequencedModelWorker
IsOnModelThread -> IsOnModelSequence

BUG=689520,731903

Review-Url: https://codereview.chromium.org/2942773002
Cr-Commit-Position: refs/heads/master@{#480569}
Committed:
https://chromium.googlesource.com/chromium/src/+/5c6a294f5b440b85ba9e9156d1f0...
==========

[commit-bot: I haz the power, 2017-06-19 20:57:15]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5c6a294f5b440b85ba9e9156d1f0...