Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2942763002: Late night strong mode cleaning. (Closed)

Created:
3 years, 6 months ago by ahe
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -51 lines) Patch
M pkg/compiler/lib/src/deferred_load.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/resolution_types.dart View 4 chunks +6 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/platform_configuration.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/typechecker.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/testing_strong.json View 6 chunks +6 lines, -13 lines 0 comments Download
M pkg/front_end/test/fasta/testing.json View 1 chunk +1 line, -9 lines 0 comments Download
M tests/compiler/dart2js/inference/enumerator.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/inference/id_equivalence_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/kernel/class_hierarchy_test.dart View 2 chunks +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/kernel/impact_test.dart View 3 chunks +6 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/kernel/visitor_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/location_collector_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/compiler/dart2js/source_map_validator_helper.dart View 5 chunks +6 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/sourcemaps/sourcemap_helper.dart View 4 chunks +3 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 5 (2 generated)
ahe
I need to get a hobby ;-)
3 years, 6 months ago (2017-06-14 20:44:58 UTC) #2
Emily Fortuna
LGTM. You, sir, are on a roll!
3 years, 6 months ago (2017-06-14 21:05:14 UTC) #3
ahe
3 years, 6 months ago (2017-06-15 07:44:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b4066914eb214193378d548bc2eb2fd269e13345 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698