extensions/browser/api/cast_channel/cast_channel_api.cc - Issue 2942743002: [cast_channel] Clean up CastSocketImpl ctor parameters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/cast_channel/cast_channel_api.cc

Issue 2942743002: [cast_channel] Clean up CastSocketImpl ctor parameters (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/cast_channel/cast_channel_api.cc

diff --git a/extensions/browser/api/cast_channel/cast_channel_api.cc b/extensions/browser/api/cast_channel/cast_channel_api.cc

index b769c3954ecbd169076a81e85e4f2ff9447ec5a6..6454b8c592a8553f8b9be7ea2d7267688b840638 100644

--- a/extensions/browser/api/cast_channel/cast_channel_api.cc

+++ b/extensions/browser/api/cast_channel/cast_channel_api.cc

@@ -294,8 +294,7 @@ void CastChannelOpenFunction::AsyncWorkStart() {

socket = test_socket.release();

} else {

socket = new CastSocketImpl(

- extension_->id(), *ip_endpoint_, channel_auth_,

- ExtensionsBrowserClient::Get()->GetNetLog(),

+ *ip_endpoint_, ExtensionsBrowserClient::Get()->GetNetLog(),

base::TimeDelta::FromMilliseconds(connect_info.timeout.get()

? *connect_info.timeout

: kDefaultConnectTimeoutMillis),