[cast_channel] Clean up CastSocketImpl ctor parameters

extensions/browser/api/cast_channel/cast_channel_api.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/api/cast_channel/cast_channel_api.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <limits>
@@ skipping 260 matching lines @@
       SetError("livenessTimeout and pingInterval must be set together.");
     } else if (liveness_timeout_ < ping_interval_) {
       SetError("livenessTimeout must be longer than pingTimeout.");
     }
   }
 
   if (!GetError().empty()) {
     return false;
   }
 
   channel_auth_ =

[imcheng, 2017/06/14 22:25:34]

channel_auth_ isn't used anymore and can be removed.

[zhaobin, 2017/06/15 02:22:22]

Done.

       api::cast_channel::ToChannelAuthTypeInternal(connect_info.auth);
   ip_endpoint_.reset(ParseConnectInfo(connect_info));
   return true;
 }
 
 void CastChannelOpenFunction::AsyncWorkStart() {
   DCHECK(api_);
   DCHECK(ip_endpoint_.get());
   const ConnectInfo& connect_info = params_->connect_info;
   CastSocket* socket;
   std::unique_ptr<CastSocket> test_socket = api_->GetSocketForTest();
   if (test_socket.get()) {
     socket = test_socket.release();
   } else {
     socket = new CastSocketImpl(
-        extension_->id(), *ip_endpoint_, channel_auth_,
-        ExtensionsBrowserClient::Get()->GetNetLog(),
+        *ip_endpoint_, ExtensionsBrowserClient::Get()->GetNetLog(),
         base::TimeDelta::FromMilliseconds(connect_info.timeout.get()
                                               ? *connect_info.timeout
                                               : kDefaultConnectTimeoutMillis),
         liveness_timeout_ > base::TimeDelta(), api_->GetLogger(),
         connect_info.capabilities.get() ? *connect_info.capabilities
                                         : CastDeviceCapability::NONE);
   }
   new_channel_id_ = cast_socket_service_->AddSocket(base::WrapUnique(socket));
 
   // Construct read delegates.
@@ skipping 22 matching lines @@
 
 void CastChannelOpenFunction::OnOpen(ChannelError result) {
   DCHECK_CURRENTLY_ON(BrowserThread::IO);
   VLOG(1) << "Connect finished, OnOpen invoked.";
   // TODO: If we failed to open the CastSocket, we may want to clean up here,
   // rather than relying on the extension to call close(). This can be done by
   // calling RemoveSocket() and api_->GetLogger()->ClearLastErrors(channel_id).
   if (result != ChannelError::UNKNOWN) {
     CastSocket* socket = cast_socket_service_->GetSocket(new_channel_id_);
     CHECK(socket);
     SetResultFromSocket(*socket);

[mark a. foltz, 2017/06/14 22:33:21]

In FillChannelInfo, you can hard code SSL_VERIFIED from the extension API.  Then
it should be possible to remove the internal ChannelAuthType enum as well.

[zhaobin, 2017/06/15 02:22:22]

Done.

   } else {
     // The socket is being destroyed.
     SetResultFromError(new_channel_id_,
                        api::cast_channel::CHANNEL_ERROR_UNKNOWN);
   }
 
   AsyncWorkCompleted();
 }
 
 CastChannelSendFunction::CastChannelSendFunction() { }
@@ skipping 153 matching lines @@
                                          std::move(results)));
   BrowserThread::PostTask(
       BrowserThread::UI, FROM_HERE,
       base::Bind(ui_dispatch_cb_, base::Passed(std::move(event))));
 }
 
 void CastChannelOpenFunction::CastMessageHandler::Start() {
 }
 
 }  // namespace extensions