Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Unified Diff: components/cast_channel/cast_socket.h

Issue 2942743002: [cast_channel] Clean up CastSocketImpl ctor parameters (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/cast_channel/cast_socket.cc » ('j') | components/cast_channel/cast_socket.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cast_channel/cast_socket.h
diff --git a/components/cast_channel/cast_socket.h b/components/cast_channel/cast_socket.h
index 42b354651561328fecd9bf68c53b84cf2346cdca..f2fbc340a98add4af18bc0a7de8b933dd16ea589 100644
--- a/components/cast_channel/cast_socket.h
+++ b/components/cast_channel/cast_socket.h
@@ -130,20 +130,13 @@ class CastSocket {
// code.
class CastSocketImpl : public CastSocket {
public:
- // Creates a new CastSocket that connects to |ip_endpoint| with
- // |channel_auth|. |owner_extension_id| is the id of the extension that opened
- // the socket. |channel_auth| must not be CHANNEL_AUTH_NONE.
+ // Creates a new CastSocket that connects to |ip_endpoint|.
// Parameters:
- // |owner_extension_id|: ID of the extension calling the API.
// |ip_endpoint|: IP address of the remote host.
- // |channel_auth|: Authentication method used for connecting to a Cast
- // receiver.
// |net_log|: Log of socket events.
// |connect_timeout|: Connection timeout interval.
// |logger|: Log of cast channel events.
- CastSocketImpl(const std::string& owner_extension_id,
- const net::IPEndPoint& ip_endpoint,
- ChannelAuthType channel_auth,
+ CastSocketImpl(const net::IPEndPoint& ip_endpoint,
net::NetLog* net_log,
const base::TimeDelta& connect_timeout,
imcheng 2017/06/14 22:25:34 Optional: It's fine to pass base::TimeDelta by val
zhaobin 2017/06/15 02:22:22 Fixed in another patch (https://codereview.chromiu
bool keep_alive,
@@ -152,9 +145,7 @@ class CastSocketImpl : public CastSocket {
// For test-only.
// This constructor allows for setting a custom AuthContext.
- CastSocketImpl(const std::string& owner_extension_id,
- const net::IPEndPoint& ip_endpoint,
- ChannelAuthType channel_auth,
+ CastSocketImpl(const net::IPEndPoint& ip_endpoint,
net::NetLog* net_log,
const base::TimeDelta& connect_timeout,
bool keep_alive,
« no previous file with comments | « no previous file | components/cast_channel/cast_socket.cc » ('j') | components/cast_channel/cast_socket.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698