[cast_channel] Clean up CastSocketImpl ctor parameters

components/cast_channel/cast_socket.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_CAST_CHANNEL_CAST_SOCKET_H_
 #define COMPONENTS_CAST_CHANNEL_CAST_SOCKET_H_
 
 #include <stdint.h>
 
 #include <queue>
@@ skipping 112 matching lines @@
 };
 
 // This class implements a channel between Chrome and a Cast device using a TCP
 // socket with SSL.  The channel may authenticate that the receiver is a genuine
 // Cast device.  All CastSocketImpl objects must be used only on the IO thread.
 //
 // NOTE: Not called "CastChannel" to reduce confusion with the generated API
 // code.
 class CastSocketImpl : public CastSocket {
  public:
-  // Creates a new CastSocket that connects to |ip_endpoint| with
-  // |channel_auth|. |owner_extension_id| is the id of the extension that opened
-  // the socket.  |channel_auth| must not be CHANNEL_AUTH_NONE.
+  // Creates a new CastSocket that connects to |ip_endpoint|.
   // Parameters:
-  // |owner_extension_id|: ID of the extension calling the API.
   // |ip_endpoint|: IP address of the remote host.
-  // |channel_auth|: Authentication method used for connecting to a Cast
-  //                 receiver.
   // |net_log|: Log of socket events.
   // |connect_timeout|: Connection timeout interval.
   // |logger|: Log of cast channel events.
-  CastSocketImpl(const std::string& owner_extension_id,
-                 const net::IPEndPoint& ip_endpoint,
-                 ChannelAuthType channel_auth,
+  CastSocketImpl(const net::IPEndPoint& ip_endpoint,
                  net::NetLog* net_log,
                  const base::TimeDelta& connect_timeout,

[imcheng, 2017/06/14 22:25:34]

Optional: It's fine to pass base::TimeDelta by value, as it is compact enough
and immutable.

[zhaobin, 2017/06/15 02:22:22]

Fixed in another patch (https://codereview.chromium.org/2937153002/).

                  bool keep_alive,
                  const scoped_refptr<Logger>& logger,
                  uint64_t device_capabilities);
 
   // For test-only.
   // This constructor allows for setting a custom AuthContext.
-  CastSocketImpl(const std::string& owner_extension_id,
-                 const net::IPEndPoint& ip_endpoint,
-                 ChannelAuthType channel_auth,
+  CastSocketImpl(const net::IPEndPoint& ip_endpoint,
                  net::NetLog* net_log,
                  const base::TimeDelta& connect_timeout,
                  bool keep_alive,
                  const scoped_refptr<Logger>& logger,
                  uint64_t device_capabilities,
                  const AuthContext& auth_context);
 
   // Ensures that the socket is closed.
   ~CastSocketImpl() override;
 
@@ skipping 122 matching lines @@
   void SetConnectState(proto::ConnectionState connect_state);
   void SetReadyState(ReadyState ready_state);
 
   THREAD_CHECKER(thread_checker_);
 
   // The id of the channel.
   int channel_id_;
   // The IP endpoint that the the channel is connected to.
   net::IPEndPoint ip_endpoint_;
   // Receiver authentication requested for the channel.
   ChannelAuthType channel_auth_;

[mark a. foltz, 2017/06/14 22:33:21]

It should be possible to remove this (it can only take one value).

[zhaobin, 2017/06/15 02:22:22]

Done.

   // The NetLog for this service.
   net::NetLog* net_log_;
   // The NetLog source for this service.
   net::NetLogSource net_log_source_;
   // True when keep-alive signaling should be handled for this socket.
   bool keep_alive_;
 
   // Shared logging object, used to log CastSocket events for diagnostics.
   scoped_refptr<Logger> logger_;
 
@@ skipping 74 matching lines @@
 
   // Raw pointer to the auth handshake delegate. Used to get detailed error
   // information.
   AuthTransportDelegate* auth_delegate_;
 
   DISALLOW_COPY_AND_ASSIGN(CastSocketImpl);
 };
 }  // namespace cast_channel
 
 #endif  // COMPONENTS_CAST_CHANNEL_CAST_SOCKET_H_