Chromium Code Reviews
DescriptionRevert of "Find" scrolling should be smoothly animated. (patchset #3 id:40001 of https://codereview.chromium.org/2935813002/ )
Reason for revert:
I believe this is a usability regression on desktop. Please reconsider, and perhaps it should be a mobile-only feature if it's an attempt to copy iOS Safari.
Original issue's description:
> "Find" scrolling should be smoothly animated.
>
> Previously, when we "Find" (Ctr + F) something in the webpage, the page
> abruptly scrolls the element into view, which makes it harder for users' eyes
> to keep track. As Safari is using smooth scroll for the "Find" feature, we
> implement this feature by setting the ScrollBehavior as "smooth" when calling
> scrollRectoToVisible().
>
> BUG=702966
>
> Review-Url: https://codereview.chromium.org/2935813002
> Cr-Commit-Position: refs/heads/master@{#479133}
> Committed: https://chromium.googlesource.com/chromium/src/+/e790c147386fdd83a00c71b62a54908a73a27dd6
TBR=bokan@chromium.org,sunyunjia@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=702966
Review-Url: https://codereview.chromium.org/2942673002
Cr-Commit-Position: refs/heads/master@{#479419}
Committed: https://chromium.googlesource.com/chromium/src/+/e904789cbf296d563ebe5ce0a8c8414f9da41d2f
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||