Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 2942673002: Revert of "Find" scrolling should be smoothly animated. (Closed)

Created:
3 years, 6 months ago by scottmg
Modified:
3 years, 6 months ago
Reviewers:
sunyunjia, bokan
CC:
chromium-reviews, blink-reviews, kinuko+watch, platform-architecture-syd+reviews-web_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of "Find" scrolling should be smoothly animated. (patchset #3 id:40001 of https://codereview.chromium.org/2935813002/ ) Reason for revert: I believe this is a usability regression on desktop. Please reconsider, and perhaps it should be a mobile-only feature if it's an attempt to copy iOS Safari. Original issue's description: > "Find" scrolling should be smoothly animated. > > Previously, when we "Find" (Ctr + F) something in the webpage, the page > abruptly scrolls the element into view, which makes it harder for users' eyes > to keep track. As Safari is using smooth scroll for the "Find" feature, we > implement this feature by setting the ScrollBehavior as "smooth" when calling > scrollRectoToVisible(). > > BUG=702966 > > Review-Url: https://codereview.chromium.org/2935813002 > Cr-Commit-Position: refs/heads/master@{#479133} > Committed: https://chromium.googlesource.com/chromium/src/+/e790c147386fdd83a00c71b62a54908a73a27dd6 TBR=bokan@chromium.org,sunyunjia@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=702966 Review-Url: https://codereview.chromium.org/2942673002 Cr-Commit-Position: refs/heads/master@{#479419} Committed: https://chromium.googlesource.com/chromium/src/+/e904789cbf296d563ebe5ce0a8c8414f9da41d2f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -58 lines) Patch
M third_party/WebKit/Source/core/dom/Element.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/Editor.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.h View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 2 chunks +3 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/web/tests/SmoothScrollTest.cpp View 2 chunks +0 lines, -27 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
scottmg
Created Revert of "Find" scrolling should be smoothly animated.
3 years, 6 months ago (2017-06-14 16:44:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2942673002/1
3 years, 6 months ago (2017-06-14 16:44:31 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-06-14 16:45:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e904789cbf296d563ebe5ce0a8c8...

Powered by Google App Engine
This is Rietveld 408576698