Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: chrome/common/BUILD.gn

Issue 2942643002: Break up the chrome/common:common target (Closed)
Patch Set: fix analyze issue Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_watcher/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/BUILD.gn
diff --git a/chrome/common/BUILD.gn b/chrome/common/BUILD.gn
index e975e3e0f8f3d243296a4b7c0fab380f9adba013..5917ab6bebf546525840f5929d05e72e2034a3fc 100644
--- a/chrome/common/BUILD.gn
+++ b/chrome/common/BUILD.gn
@@ -574,6 +574,24 @@ process_version("version_header") {
output = "$target_gen_dir/chrome_version.h"
}
+# This target allows using logging_chrome without depending on the rest of
+# chrome/common.
+static_library("logging") {
agrieve 2017/06/14 15:45:48 Would this make more sense as a source_set? gn he
+ sources = [
+ "logging_chrome.cc",
+ "logging_chrome.h",
+ ]
+ deps = [
+ ":constants",
+ "//base",
+ "//content/public/common",
+ "//ipc",
+ ]
+ if (is_win) {
+ deps += [ "//chrome/install_static:install_static_util" ]
+ }
+}
+
static_library("constants") {
sources = [
"chrome_constants.cc",
« no previous file with comments | « chrome/chrome_watcher/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698