Break up the chrome/common:common target

chrome/common/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/buildflag_header.gni")
 import("//build/util/process_version.gni")
 import("//chrome/common/features.gni")
 import("//chrome/process_version_rc_template.gni")  # For branding_file_path.
 import("//extensions/features/features.gni")
 import("//mojo/public/tools/bindings/mojom.gni")
@@ skipping 556 matching lines @@
   sources = [
     "//build/util/LASTCHANGE",
     "//chrome/VERSION",
     branding_file_path,
   ]
   template_file = "chrome_version.h.in"
 
   output = "$target_gen_dir/chrome_version.h"
 }
 
+# This target allows using logging_chrome without depending on the rest of
+# chrome/common.
+static_library("logging") {

[agrieve, 2017/06/14 15:45:48]

Would this make more sense as a source_set?

gn help static_library says:

  If you only need the static library for intermediate results in the build,
  you should consider a source_set instead since it will skip the (potentially
  slow) step of creating the intermediate library file.

+  sources = [
+    "logging_chrome.cc",
+    "logging_chrome.h",
+  ]
+  deps = [
+    ":constants",
+    "//base",
+    "//content/public/common",
+    "//ipc",
+  ]
+  if (is_win) {
+    deps += [ "//chrome/install_static:install_static_util" ]
+  }
+}
+
 static_library("constants") {
   sources = [
     "chrome_constants.cc",
     "chrome_constants.h",
     "chrome_features.cc",
     "chrome_features.h",
     "chrome_icon_resources_win.h",
     "chrome_paths.cc",
     "chrome_paths.h",
     "chrome_paths_android.cc",
@@ skipping 183 matching lines @@
 
 mojom("page_load_metrics_mojom") {
   sources = [
     "page_load_metrics/page_load_metrics.mojom",
   ]
 
   public_deps = [
     "//mojo/common:common_custom_types",
   ]
 }