Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2942623003: Make WebLocalFrameImpl::Load() to reset active match (Closed)

Created:
3 years, 6 months ago by yosin_UTC9
Modified:
3 years, 6 months ago
Reviewers:
tkent
CC:
blink-reviews, chromium-reviews, kinuko+watch, platform-architecture-syd+reviews-web_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make WebLocalFrameImpl::Load() to reset active match This patch changes |WebLocalFrameImpl::Load()| to reset active match, which is represented by |Range|, to avoid setting selection with document not hosted by |WebLocalFrameImpl|. This is caused by processing |WebLocalFrame::StopFInding()| with |kStopFindActionKeepSelection| from |FindRequestManager| in browser process is happend after completion of loading document. BUG=719880 TEST=run_webkit_unit_tests All/ParameterizedWebFrameTest.FindInPageStopFindActionKeepSelectionInAnotherDocument/* Review-Url: https://codereview.chromium.org/2942623003 Cr-Commit-Position: refs/heads/master@{#479636} Committed: https://chromium.googlesource.com/chromium/src/+/7920530b27ad7c75a12f02b410ba8dbf923a2df8

Patch Set 1 : 2017-06-15T14:26:20 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (18 generated)
yosin_UTC9
PTAL
3 years, 6 months ago (2017-06-15 06:39:15 UTC) #14
tkent
lgtm
3 years, 6 months ago (2017-06-15 07:14:10 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2942623003/40001
3 years, 6 months ago (2017-06-15 07:29:41 UTC) #18
commit-bot: I haz the power
3 years, 6 months ago (2017-06-15 08:15:10 UTC) #22
Message was sent while issue was closed.
Committed patchset #1 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7920530b27ad7c75a12f02b410ba...

Powered by Google App Engine
This is Rietveld 408576698