|
|
Chromium Code Reviews|
Created:
3 years, 6 months ago by yosin_UTC9 Modified:
3 years, 6 months ago Reviewers:
tkent CC:
blink-reviews, chromium-reviews, kinuko+watch, platform-architecture-syd+reviews-web_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionMake WebLocalFrameImpl::Load() to reset active match
This patch changes |WebLocalFrameImpl::Load()| to reset active match, which is
represented by |Range|, to avoid setting selection with document not hosted
by |WebLocalFrameImpl|.
This is caused by processing
|WebLocalFrame::StopFInding()| with |kStopFindActionKeepSelection| from
|FindRequestManager| in browser process is happend after completion of
loading document.
BUG=719880
TEST=run_webkit_unit_tests All/ParameterizedWebFrameTest.FindInPageStopFindActionKeepSelectionInAnotherDocument/*
Review-Url: https://codereview.chromium.org/2942623003
Cr-Commit-Position: refs/heads/master@{#479636}
Committed: https://chromium.googlesource.com/chromium/src/+/7920530b27ad7c75a12f02b410ba8dbf923a2df8
Patch Set 1 : 2017-06-15T14:26:20 #
Messages
Total messages: 22 (18 generated)
Description was changed from ========== 2017-06-15T13:35:04 BUG=719880 2017-06-15T13:34:10 ========== to ========== Make WebLocalFrameImpl::SetFindEndstateFocusAndSelection() not to use active match for another document BUG=719880 2017-06-15T13:34:10 ==========
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Make WebLocalFrameImpl::SetFindEndstateFocusAndSelection() not to use active match for another document BUG=719880 2017-06-15T13:34:10 ========== to ========== Make WebLocalFrameImpl::Load() to reset active match This patch changes |WebLocalFrameImpl::Load()| to reset active match, which is represented by |Range|, to avoid setting selection with document not hosted by |WebLocalFrameImpl|. This is caused by calling |WebLocalFrame::StopFInding()| with |kStopFindActionKeepSelection| after loading document. BUG=719880 TEST=run_webkit_unit_tests All/ParameterizedWebFrameTest.FindInPageSetFindEndstateFocusAndSelection/* ==========
Description was changed from ========== Make WebLocalFrameImpl::Load() to reset active match This patch changes |WebLocalFrameImpl::Load()| to reset active match, which is represented by |Range|, to avoid setting selection with document not hosted by |WebLocalFrameImpl|. This is caused by calling |WebLocalFrame::StopFInding()| with |kStopFindActionKeepSelection| after loading document. BUG=719880 TEST=run_webkit_unit_tests All/ParameterizedWebFrameTest.FindInPageSetFindEndstateFocusAndSelection/* ========== to ========== Make WebLocalFrameImpl::Load() to reset active match This patch changes |WebLocalFrameImpl::Load()| to reset active match, which is represented by |Range|, to avoid setting selection with document not hosted by |WebLocalFrameImpl|. This is caused by processing |WebLocalFrame::StopFInding()| with |kStopFindActionKeepSelection| from |FindRequestManager| in browser process is happend after completion of loading document. BUG=719880 TEST=run_webkit_unit_tests All/ParameterizedWebFrameTest.FindInPageSetFindEndstateFocusAndSelection/* ==========
Description was changed from ========== Make WebLocalFrameImpl::Load() to reset active match This patch changes |WebLocalFrameImpl::Load()| to reset active match, which is represented by |Range|, to avoid setting selection with document not hosted by |WebLocalFrameImpl|. This is caused by processing |WebLocalFrame::StopFInding()| with |kStopFindActionKeepSelection| from |FindRequestManager| in browser process is happend after completion of loading document. BUG=719880 TEST=run_webkit_unit_tests All/ParameterizedWebFrameTest.FindInPageSetFindEndstateFocusAndSelection/* ========== to ========== Make WebLocalFrameImpl::Load() to reset active match This patch changes |WebLocalFrameImpl::Load()| to reset active match, which is represented by |Range|, to avoid setting selection with document not hosted by |WebLocalFrameImpl|. This is caused by processing |WebLocalFrame::StopFInding()| with |kStopFindActionKeepSelection| from |FindRequestManager| in browser process is happend after completion of loading document. BUG=719880 TEST=run_webkit_unit_tests All/ParameterizedWebFrameTest.FindInPageStopFindActionKeepSelectionInAnotherDocument/* ==========
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
Patchset #2 (id:20001) has been deleted
Patchset #1 (id:1) has been deleted
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
yosin@chromium.org changed reviewers: + tkent@chromium.org
PTAL
lgtm
The CQ bit was unchecked by yosin@chromium.org
The CQ bit was checked by yosin@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497511776834030,
"parent_rev": "772e2f76cdab92e73a50192f07b2ea7036c06b79", "commit_rev":
"9ee03af276064894770f01792e23bc66ea97976e"}
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497511776834030,
"parent_rev": "7cb90dcac57732686408a127941865df2aa2b577", "commit_rev":
"7920530b27ad7c75a12f02b410ba8dbf923a2df8"}
Message was sent while issue was closed.
Description was changed from ========== Make WebLocalFrameImpl::Load() to reset active match This patch changes |WebLocalFrameImpl::Load()| to reset active match, which is represented by |Range|, to avoid setting selection with document not hosted by |WebLocalFrameImpl|. This is caused by processing |WebLocalFrame::StopFInding()| with |kStopFindActionKeepSelection| from |FindRequestManager| in browser process is happend after completion of loading document. BUG=719880 TEST=run_webkit_unit_tests All/ParameterizedWebFrameTest.FindInPageStopFindActionKeepSelectionInAnotherDocument/* ========== to ========== Make WebLocalFrameImpl::Load() to reset active match This patch changes |WebLocalFrameImpl::Load()| to reset active match, which is represented by |Range|, to avoid setting selection with document not hosted by |WebLocalFrameImpl|. This is caused by processing |WebLocalFrame::StopFInding()| with |kStopFindActionKeepSelection| from |FindRequestManager| in browser process is happend after completion of loading document. BUG=719880 TEST=run_webkit_unit_tests All/ParameterizedWebFrameTest.FindInPageStopFindActionKeepSelectionInAnotherDocument/* Review-Url: https://codereview.chromium.org/2942623003 Cr-Commit-Position: refs/heads/master@{#479636} Committed: https://chromium.googlesource.com/chromium/src/+/7920530b27ad7c75a12f02b410ba... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:40001) as https://chromium.googlesource.com/chromium/src/+/7920530b27ad7c75a12f02b410ba... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
