Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 2942623002: VR: Add support for mouse down/up events for Android NativePages. (Closed)

Created:
3 years, 6 months ago by mthiesse
Modified:
3 years, 6 months ago
Reviewers:
Ian Vollick
CC:
chromium-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

VR: Add support for mouse down/up events for Android NativePages. BUG=732917 Review-Url: https://codereview.chromium.org/2942623002 Cr-Commit-Position: refs/heads/master@{#479402} Committed: https://chromium.googlesource.com/chromium/src/+/2a36d1978df99e98cf8696c5824bb8050f514928

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M chrome/browser/android/vr_shell/android_ui_gesture_target.cc View 1 chunk +13 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
mthiesse
PTAL
3 years, 6 months ago (2017-06-14 14:54:27 UTC) #2
Ian Vollick
On 2017/06/14 14:54:27, mthiesse wrote: > PTAL lgtm.
3 years, 6 months ago (2017-06-14 15:02:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2942623002/1
3 years, 6 months ago (2017-06-14 15:04:17 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-14 16:00:28 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2a36d1978df99e98cf8696c5824b...

Powered by Google App Engine
This is Rietveld 408576698