[heap] Allow a minimum semi-space size of 512K.

[heap] Allow a minimum semi-space size of 512K.

This CL also reduces the minimum semi-space size to 512K.

BUG=chromium:716032
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng

Review-Url: https://codereview.chromium.org/2942543002
Cr-Commit-Position: refs/heads/master@{#45992}
Committed: https://chromium.googlesource.com/v8/v8/+/0d2ed6c3287ec48ee06ec1b69287ed4bf0dd60d7

[Hannes Payer (out of office), 2017-06-14 06:46:44]

Description was changed from

==========
[heap] Allow a minimum semi-space size of 512K.

BUG=chromium:716032
==========

to

==========
[heap] Allow a minimum semi-space size of 512K.

BUG=chromium:716032
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng
==========

[Hannes Payer (out of office), 2017-06-14 06:46:49]

The CQ bit was checked by hpayer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-14 06:47:00]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hannes Payer (out of office), 2017-06-14 07:12:49]

The CQ bit was checked by hpayer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-14 07:12:52]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hannes Payer (out of office), 2017-06-14 07:13:38]

Description was changed from

==========
[heap] Allow a minimum semi-space size of 512K.

BUG=chromium:716032
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng
==========

to

==========
[heap] Allow a minimum semi-space size of 512K.

BUG=chromium:716032
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng
==========

[Hannes Payer (out of office), 2017-06-14 07:13:38]

hpayer@chromium.org changed reviewers:
+ mlippautz@chromium.org

[Michael Lippautz, 2017-06-14 07:25:09]

https://codereview.chromium.org/2942543002/diff/60001/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/2942543002/diff/60001/include/v8.h#newcode5984
include/v8.h:5984: int max_semi_space_size() const { return
max_semi_space_size_in_kb_ / 1024; }
Maybe deprecate?

https://codereview.chromium.org/2942543002/diff/60001/include/v8.h#newcode5992
include/v8.h:5992: int max_semi_space_size_in_kb() const { return
max_semi_space_size_in_kb_; }
I know that everything here is int, but should we introduce new APIs with
size_t? E.g. code_range_size_ is already size_t.

https://codereview.chromium.org/2942543002/diff/60001/src/heap/heap.cc
File src/heap/heap.cc (right):

https://codereview.chromium.org/2942543002/diff/60001/src/heap/heap.cc#newcode88
src/heap/heap.cc:88: initial_semispace_size_(Page::kPageSize),
This would not only allow, but also change the minimum size to 512k, right?
Should we do this in a separate CL? If this should go into this CL adjust the
description.

https://codereview.chromium.org/2942543002/diff/60001/src/heap/heap.h
File src/heap/heap.h (right):

https://codereview.chromium.org/2942543002/diff/60001/src/heap/heap.h#newcode...
src/heap/heap.h:1367: return RoundUp(semi_space_size_in_kb, (1 << kPageSizeBits)
/ 1024);
nit: KB

[Hannes Payer (out of office), 2017-06-14 07:46:43]

Description was changed from

==========
[heap] Allow a minimum semi-space size of 512K.

BUG=chromium:716032
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng
==========

to

==========
[heap] Allow a minimum semi-space size of 512K.

This CL also reduces the minimum semi-space size to 512K.

BUG=chromium:716032
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng
==========

[jochen (gone - plz use gerrit), 2017-06-14 07:50:24]

jochen@chromium.org changed reviewers:
+ jochen@chromium.org

[jochen (gone - plz use gerrit), 2017-06-14 07:50:25]

include/ lgtm

[Hannes Payer (out of office), 2017-06-14 07:57:02]

https://codereview.chromium.org/2942543002/diff/60001/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/2942543002/diff/60001/include/v8.h#newcode5984
include/v8.h:5984: int max_semi_space_size() const { return
max_semi_space_size_in_kb_ / 1024; }
On 2017/06/14 07:25:08, Michael Lippautz wrote:
> Maybe deprecate?

Done.

https://codereview.chromium.org/2942543002/diff/60001/include/v8.h#newcode5992
include/v8.h:5992: int max_semi_space_size_in_kb() const { return
max_semi_space_size_in_kb_; }
On 2017/06/14 07:25:08, Michael Lippautz wrote:
> I know that everything here is int, but should we introduce new APIs with
> size_t? E.g. code_range_size_ is already size_t.

Done.

https://codereview.chromium.org/2942543002/diff/60001/src/heap/heap.cc
File src/heap/heap.cc (right):

https://codereview.chromium.org/2942543002/diff/60001/src/heap/heap.cc#newcode88
src/heap/heap.cc:88: initial_semispace_size_(Page::kPageSize),
On 2017/06/14 07:25:08, Michael Lippautz wrote:
> This would not only allow, but also change the minimum size to 512k, right?
> Should we do this in a separate CL? If this should go into this CL adjust the
> description.

Absolutely intentional. Done.

https://codereview.chromium.org/2942543002/diff/60001/src/heap/heap.h
File src/heap/heap.h (right):

https://codereview.chromium.org/2942543002/diff/60001/src/heap/heap.h#newcode...
src/heap/heap.h:1367: return RoundUp(semi_space_size_in_kb, (1 << kPageSizeBits)
/ 1024);
On 2017/06/14 07:25:08, Michael Lippautz wrote:
> nit: KB

Done.

[Michael Lippautz, 2017-06-14 08:07:48]

lgtm

[Hannes Payer (out of office), 2017-06-14 11:53:19]

The CQ bit was checked by hpayer@chromium.org

[commit-bot: I haz the power, 2017-06-14 11:53:25]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-14 11:59:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-14 11:59:35]

Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[Hannes Payer (out of office), 2017-06-16 10:57:04]

The CQ bit was checked by hpayer@chromium.org

[Hannes Payer (out of office), 2017-06-16 10:57:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlippautz@chromium.org, jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2942543002/#ps100001
(title: "remove const")

[commit-bot: I haz the power, 2017-06-16 10:57:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 11:05:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-16 11:05:58]

Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[Hannes Payer (out of office), 2017-06-16 11:21:36]

The CQ bit was checked by hpayer@chromium.org

[Hannes Payer (out of office), 2017-06-16 11:21:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlippautz@chromium.org, jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2942543002/#ps120001
(title: "test api")

[commit-bot: I haz the power, 2017-06-16 11:21:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 11:28:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-16 11:28:36]

Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[Hannes Payer (out of office), 2017-06-19 09:16:17]

The CQ bit was checked by hpayer@chromium.org

[Hannes Payer (out of office), 2017-06-19 09:16:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlippautz@chromium.org, jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2942543002/#ps140001
(title: "kb")

[commit-bot: I haz the power, 2017-06-19 09:16:26]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-19 10:16:14]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1497863777768210,
"parent_rev": "bc717ae84ba74ba9d140e1cb7be8eea37f199e46", "commit_rev":
"0d2ed6c3287ec48ee06ec1b69287ed4bf0dd60d7"}

[commit-bot: I haz the power, 2017-06-19 10:16:21]

Description was changed from

==========
[heap] Allow a minimum semi-space size of 512K.

This CL also reduces the minimum semi-space size to 512K.

BUG=chromium:716032
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng
==========

to

==========
[heap] Allow a minimum semi-space size of 512K.

This CL also reduces the minimum semi-space size to 512K.

BUG=chromium:716032
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng

Review-Url: https://codereview.chromium.org/2942543002
Cr-Commit-Position: refs/heads/master@{#45992}
Committed:
https://chromium.googlesource.com/v8/v8/+/0d2ed6c3287ec48ee06ec1b69287ed4bf0d...
==========

[commit-bot: I haz the power, 2017-06-19 10:16:22]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/v8/v8/+/0d2ed6c3287ec48ee06ec1b69287ed4bf0d...