Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5717)

Unified Diff: chrome/browser/installable/installable_manager_unittest.cc

Issue 2942513002: Allow banners to trigger on sites which don't register a service worker onload. (Closed)
Patch Set: Don't cache NO_MATCHING_SERVICE_WORKER Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/installable/installable_manager_browsertest.cc ('k') | tools/metrics/histograms/enums.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/installable/installable_manager_unittest.cc
diff --git a/chrome/browser/installable/installable_manager_unittest.cc b/chrome/browser/installable/installable_manager_unittest.cc
index deef909525cf8e9986f0d63a85e6bb87aa4a4464..eb5bfa4d19156fb9aceea5006c5e43d30c06b353 100644
--- a/chrome/browser/installable/installable_manager_unittest.cc
+++ b/chrome/browser/installable/installable_manager_unittest.cc
@@ -12,7 +12,8 @@ using IconPurpose = content::Manifest::Icon::IconPurpose;
class InstallableManagerUnitTest : public testing::Test {
public:
- InstallableManagerUnitTest() : manager_(new InstallableManager(nullptr)) { }
+ InstallableManagerUnitTest()
+ : manager_(base::MakeUnique<InstallableManager>(nullptr)) {}
protected:
static base::NullableString16 ToNullableUTF16(const std::string& str) {
@@ -39,12 +40,12 @@ class InstallableManagerUnitTest : public testing::Test {
bool IsManifestValid(const content::Manifest& manifest) {
// Explicitly reset the error code before running the method.
- manager_->set_installable_error(NO_ERROR_DETECTED);
+ manager_->set_valid_manifest_error(NO_ERROR_DETECTED);
return manager_->IsManifestValidForWebApp(manifest);
}
InstallableStatusCode GetErrorCode() {
- return manager_->installable_error();
+ return manager_->valid_manifest_error();
}
private:
« no previous file with comments | « chrome/browser/installable/installable_manager_browsertest.cc ('k') | tools/metrics/histograms/enums.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698