Allow banners to trigger on sites which don't register a service worker onload.

chrome/browser/installable/installable_manager_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/installable/installable_manager.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/WebKit/public/platform/WebDisplayMode.h"
 
 using IconPurpose = content::Manifest::Icon::IconPurpose;
 
 class InstallableManagerUnitTest : public testing::Test {
  public:
-  InstallableManagerUnitTest() : manager_(new InstallableManager(nullptr)) { }
+  InstallableManagerUnitTest()
+      : manager_(base::MakeUnique<InstallableManager>(nullptr)) {}
 
  protected:
   static base::NullableString16 ToNullableUTF16(const std::string& str) {
     return base::NullableString16(base::UTF8ToUTF16(str), false);
   }
 
   static content::Manifest GetValidManifest() {
     content::Manifest manifest;
     manifest.name = ToNullableUTF16("foo");
     manifest.short_name = ToNullableUTF16("bar");
     manifest.start_url = GURL("http://example.com");
     manifest.display = blink::kWebDisplayModeStandalone;
 
     content::Manifest::Icon primary_icon;
     primary_icon.type = base::ASCIIToUTF16("image/png");
     primary_icon.sizes.push_back(gfx::Size(144, 144));
     primary_icon.purpose.push_back(IconPurpose::ANY);
     manifest.icons.push_back(primary_icon);
 
     // No need to include the optional badge icon as it does not affect the
     // unit tests.
     return manifest;
   }
 
   bool IsManifestValid(const content::Manifest& manifest) {
     // Explicitly reset the error code before running the method.
-    manager_->set_installable_error(NO_ERROR_DETECTED);
+    manager_->set_valid_manifest_error(NO_ERROR_DETECTED);
     return manager_->IsManifestValidForWebApp(manifest);
   }
 
   InstallableStatusCode GetErrorCode() {
-    return manager_->installable_error();
+    return manager_->valid_manifest_error();
   }
 
  private:
   std::unique_ptr<InstallableManager> manager_;
 };
 
 TEST_F(InstallableManagerUnitTest, EmptyManifestIsInvalid) {
   content::Manifest manifest;
   EXPECT_FALSE(IsManifestValid(manifest));
   EXPECT_EQ(MANIFEST_EMPTY, GetErrorCode());
@@ skipping 141 matching lines @@
   EXPECT_EQ(MANIFEST_DISPLAY_NOT_SUPPORTED, GetErrorCode());
 
   manifest.display = blink::kWebDisplayModeStandalone;
   EXPECT_TRUE(IsManifestValid(manifest));
   EXPECT_EQ(NO_ERROR_DETECTED, GetErrorCode());
 
   manifest.display = blink::kWebDisplayModeFullscreen;
   EXPECT_TRUE(IsManifestValid(manifest));
   EXPECT_EQ(NO_ERROR_DETECTED, GetErrorCode());
 }