chrome/browser/installable/installable_logging.h - Issue 2942513002: Allow banners to trigger on sites which don't register a service worker onload.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/installable/installable_logging.h

Issue 2942513002: Allow banners to trigger on sites which don't register a service worker onload. (Closed)

Patch Set: Fix windows compile Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/banners/app_banner_manager.cc ('K') | « chrome/browser/banners/app_banner_manager_browsertest.cc ('k') | chrome/browser/installable/installable_logging.cc » ('j') | chrome/browser/installable/installable_manager.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_INSTALLABLE_INSTALLABLE_LOGGING_H_	5 #ifndef CHROME_BROWSER_INSTALLABLE_INSTALLABLE_LOGGING_H_

6 #define CHROME_BROWSER_INSTALLABLE_INSTALLABLE_LOGGING_H_	6 #define CHROME_BROWSER_INSTALLABLE_INSTALLABLE_LOGGING_H_

7	7

8 #include <string>	8 #include <string>

9	9

10 namespace content {	10 namespace content {

(...skipping 29 matching lines...) Expand all Loading...
40 INSUFFICIENT_ENGAGEMENT,	40 INSUFFICIENT_ENGAGEMENT,

41 PACKAGE_NAME_OR_START_URL_EMPTY,	41 PACKAGE_NAME_OR_START_URL_EMPTY,

42 PREVIOUSLY_BLOCKED,	42 PREVIOUSLY_BLOCKED,

43 PREVIOUSLY_IGNORED,	43 PREVIOUSLY_IGNORED,

44 SHOWING_NATIVE_APP_BANNER,	44 SHOWING_NATIVE_APP_BANNER,

45 SHOWING_WEB_APP_BANNER,	45 SHOWING_WEB_APP_BANNER,

46 FAILED_TO_CREATE_BANNER,	46 FAILED_TO_CREATE_BANNER,

47 URL_NOT_SUPPORTED_FOR_WEBAPK,	47 URL_NOT_SUPPORTED_FOR_WEBAPK,

48 IN_INCOGNITO,	48 IN_INCOGNITO,

49 NOT_OFFLINE_CAPABLE,	49 NOT_OFFLINE_CAPABLE,

	50 WAITING_FOR_MANIFEST,

	51 WAITING_FOR_INSTALLABLE_CHECK,

50 MAX_ERROR_CODE,	52 MAX_ERROR_CODE,

51 };	53 };

52	54

53 // Logs a message associated with \|code\| with a parameter \|param\| to the	55 // Logs a message associated with \|code\| with a parameter \|param\| to the

54 // devtools console attached to \|web_contents\|. Does nothing if \|web_contents\|	56 // devtools console attached to \|web_contents\|. Does nothing if \|web_contents\|

55 // is nullptr.	57 // is nullptr.

56 void LogErrorToConsole(content::WebContents* web_contents,	58 void LogErrorToConsole(content::WebContents* web_contents,

57 InstallableStatusCode code,	59 InstallableStatusCode code,

58 const std::string& param);	60 const std::string& param);

59	61

60 #endif // CHROME_BROWSER_INSTALLABLE_INSTALLABLE_LOGGING_H_	62 #endif // CHROME_BROWSER_INSTALLABLE_INSTALLABLE_LOGGING_H_

OLD	NEW