Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2020)

Side by Side Diff: chrome/browser/banners/app_banner_manager_browsertest.cc

Issue 2942513002: Allow banners to trigger on sites which don't register a service worker onload. (Closed)
Patch Set: Fix windows compile Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <vector> 5 #include <vector>
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/memory/ptr_util.h" 9 #include "base/memory/ptr_util.h"
10 #include "base/run_loop.h" 10 #include "base/run_loop.h"
(...skipping 215 matching lines...) Expand 10 before | Expand all | Expand 10 after
226 226
227 IN_PROC_BROWSER_TEST_F(AppBannerManagerBrowserTest, WebAppBannerCreated) { 227 IN_PROC_BROWSER_TEST_F(AppBannerManagerBrowserTest, WebAppBannerCreated) {
228 std::unique_ptr<AppBannerManagerTest> manager( 228 std::unique_ptr<AppBannerManagerTest> manager(
229 CreateAppBannerManager(browser())); 229 CreateAppBannerManager(browser()));
230 std::vector<double> engagement_scores{0, 10}; 230 std::vector<double> engagement_scores{0, 10};
231 RunBannerTest(browser(), manager.get(), "/banners/manifest_test_page.html", 231 RunBannerTest(browser(), manager.get(), "/banners/manifest_test_page.html",
232 engagement_scores, SHOWING_WEB_APP_BANNER, true); 232 engagement_scores, SHOWING_WEB_APP_BANNER, true);
233 } 233 }
234 234
235 IN_PROC_BROWSER_TEST_F(AppBannerManagerBrowserTest, 235 IN_PROC_BROWSER_TEST_F(AppBannerManagerBrowserTest,
236 WebAppBannerLazyServiceWorker) {
237 std::unique_ptr<AppBannerManagerTest> manager(
238 CreateAppBannerManager(browser()));
239 std::vector<double> engagement_scores{0, 10};
240 RunBannerTest(browser(), manager.get(),
241 "/banners/lazy_service_worker_test_page.html",
242 engagement_scores, SHOWING_WEB_APP_BANNER, true);
243 }
244
245 IN_PROC_BROWSER_TEST_F(AppBannerManagerBrowserTest,
236 WebAppBannerCreatedImmediately) { 246 WebAppBannerCreatedImmediately) {
237 std::unique_ptr<AppBannerManagerTest> manager( 247 std::unique_ptr<AppBannerManagerTest> manager(
238 CreateAppBannerManager(browser())); 248 CreateAppBannerManager(browser()));
239 std::vector<double> engagement_scores{10}; 249 std::vector<double> engagement_scores{10};
240 RunBannerTest(browser(), manager.get(), "/banners/manifest_test_page.html", 250 RunBannerTest(browser(), manager.get(), "/banners/manifest_test_page.html",
241 engagement_scores, SHOWING_WEB_APP_BANNER, true); 251 engagement_scores, SHOWING_WEB_APP_BANNER, true);
242 } 252 }
243 253
244 IN_PROC_BROWSER_TEST_F(AppBannerManagerBrowserTest, 254 IN_PROC_BROWSER_TEST_F(AppBannerManagerBrowserTest,
245 WebAppBannerCreatedAfterSeveralVisits) { 255 WebAppBannerCreatedAfterSeveralVisits) {
(...skipping 278 matching lines...) Expand 10 before | Expand all | Expand 10 after
524 EXPECT_FALSE(manager->will_show()); 534 EXPECT_FALSE(manager->will_show());
525 EXPECT_FALSE(manager->is_active()); 535 EXPECT_FALSE(manager->is_active());
526 EXPECT_FALSE(manager->need_to_log_status()); 536 EXPECT_FALSE(manager->need_to_log_status());
527 537
528 histograms.ExpectTotalCount(banners::kMinutesHistogram, 0); 538 histograms.ExpectTotalCount(banners::kMinutesHistogram, 0);
529 histograms.ExpectUniqueSample(banners::kInstallableStatusCodeHistogram, 539 histograms.ExpectUniqueSample(banners::kInstallableStatusCodeHistogram,
530 INSUFFICIENT_ENGAGEMENT, 1); 540 INSUFFICIENT_ENGAGEMENT, 1);
531 } 541 }
532 542
533 } // namespace banners 543 } // namespace banners
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698