Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2942493002: Removed unnecessary string concatenations (Closed)

Created:
3 years, 6 months ago by cbernaschina
Modified:
3 years, 6 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M runtime/observatory/lib/src/elements/cpu_profile/virtual_tree.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/elements/isolate_view.dart View 1 chunk +1 line, -1 line 1 comment Download
M runtime/observatory/lib/src/elements/metric/graph.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (3 generated)
rmacnak
lgtm https://codereview.chromium.org/2942493002/diff/1/runtime/observatory/lib/src/elements/isolate_view.dart File runtime/observatory/lib/src/elements/isolate_view.dart (right): https://codereview.chromium.org/2942493002/diff/1/runtime/observatory/lib/src/elements/isolate_view.dart#newcode384 runtime/observatory/lib/src/elements/isolate_view.dart:384: ..text = 'current zone capacity ' + another ...
3 years, 6 months ago (2017-06-14 16:18:17 UTC) #3
cbernaschina
3 years, 6 months ago (2017-06-14 18:23:22 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
f5bca80a48609c417d6cd9702f4732299bc63718 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698