 Chromium Code Reviews
 Chromium Code Reviews Issue 2942493002:
  Removed unnecessary string concatenations  (Closed)
    
  
    Issue 2942493002:
  Removed unnecessary string concatenations  (Closed) 
  | OLD | NEW | 
|---|---|
| 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file | 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file | 
| 2 // for details. All rights reserved. Use of this source code is governed by a | 2 // for details. All rights reserved. Use of this source code is governed by a | 
| 3 // BSD-style license that can be found in the LICENSE file. | 3 // BSD-style license that can be found in the LICENSE file. | 
| 4 | 4 | 
| 5 library isolate_view_element; | 5 library isolate_view_element; | 
| 6 | 6 | 
| 7 import 'dart:async'; | 7 import 'dart:async'; | 
| 8 import 'dart:html'; | 8 import 'dart:html'; | 
| 9 import 'package:observatory/models.dart' as M; | 9 import 'package:observatory/models.dart' as M; | 
| 10 import 'package:observatory/src/elements/curly_block.dart'; | 10 import 'package:observatory/src/elements/curly_block.dart'; | 
| (...skipping 358 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 369 ..children = [ | 369 ..children = [ | 
| 370 new SpanElement()..text = '${t.id} ', | 370 new SpanElement()..text = '${t.id} ', | 
| 371 new CurlyBlockElement(queue: _r.queue) | 371 new CurlyBlockElement(queue: _r.queue) | 
| 372 ..content = [ | 372 ..content = [ | 
| 373 new DivElement() | 373 new DivElement() | 
| 374 ..classes = ['indent'] | 374 ..classes = ['indent'] | 
| 375 ..text = 'kind ${t.kindString}', | 375 ..text = 'kind ${t.kindString}', | 
| 376 new DivElement() | 376 new DivElement() | 
| 377 ..classes = ['indent'] | 377 ..classes = ['indent'] | 
| 378 ..title = '${t.zoneHighWatermark}B' | 378 ..title = '${t.zoneHighWatermark}B' | 
| 379 ..text = 'zone capacity high watermark ' + | 379 ..text = 'zone capacity high watermark ' | 
| 380 '${Utils.formatSize(t.zoneHighWatermark)}', | 380 '${Utils.formatSize(t.zoneHighWatermark)}', | 
| 381 new DivElement() | 381 new DivElement() | 
| 382 ..classes = ['indent'] | 382 ..classes = ['indent'] | 
| 383 ..title = '${t.zoneCapacity}B' | 383 ..title = '${t.zoneCapacity}B' | 
| 384 ..text = 'current zone capacity ' + | 384 ..text = 'current zone capacity ' + | 
| 
rmacnak
2017/06/14 16:18:17
another one
 | |
| 385 '${Utils.formatSize(t.zoneCapacity)}', | 385 '${Utils.formatSize(t.zoneCapacity)}', | 
| 386 ] | 386 ] | 
| 387 ]; | 387 ]; | 
| 388 } | 388 } | 
| 389 | 389 | 
| 390 Future _loadExtraData() async { | 390 Future _loadExtraData() async { | 
| 391 _function = null; | 391 _function = null; | 
| 392 _rootScript = null; | 392 _rootScript = null; | 
| 393 final frame = M.topFrame(_isolate.pauseEvent); | 393 final frame = M.topFrame(_isolate.pauseEvent); | 
| 394 if (frame != null) { | 394 if (frame != null) { | 
| 395 _function = await _functions.get(_isolate, frame.function.id); | 395 _function = await _functions.get(_isolate, frame.function.id); | 
| 396 } | 396 } | 
| 397 if (_isolate.rootLibrary != null) { | 397 if (_isolate.rootLibrary != null) { | 
| 398 final rootLibrary = | 398 final rootLibrary = | 
| 399 await _libraries.get(_isolate, _isolate.rootLibrary.id); | 399 await _libraries.get(_isolate, _isolate.rootLibrary.id); | 
| 400 _rootScript = rootLibrary.rootScript; | 400 _rootScript = rootLibrary.rootScript; | 
| 401 } | 401 } | 
| 402 _r.dirty(); | 402 _r.dirty(); | 
| 403 } | 403 } | 
| 404 } | 404 } | 
| OLD | NEW |