[sync] Don't show an error icon when sync isn't signed in

components/browser_sync/profile_sync_service.cc

Index: components/browser_sync/profile_sync_service.cc
diff --git a/components/browser_sync/profile_sync_service.cc b/components/browser_sync/profile_sync_service.cc
index 6efd0397c036c4c31812accbb4f2e58031e8a55e..353c36f18ece4db263408af28cc6845580973a40 100644
--- a/components/browser_sync/profile_sync_service.cc
+++ b/components/browser_sync/profile_sync_service.cc
@@ -788,7 +788,7 @@ void ProfileSyncService::SetFirstSetupComplete() {
 
 bool ProfileSyncService::IsSyncConfirmationNeeded() const {
   DCHECK(thread_checker_.CalledOnValidThread());
-  return !IsFirstSetupInProgress() && !IsFirstSetupComplete() &&
+  return IsSignedIn() && !IsFirstSetupInProgress() && !IsFirstSetupComplete() &&
          IsSyncRequested();

[skym, 2017/06/14 17:22:18]

"IsSyncRequested()" is a confusing name. It seems like it should imply that the
user has signed in. Oh well.

Can you update the comments around the definition of kSyncSuppressStart? They
seem to be outdated.

 }