Remove references to ui/views/layout/layout_constants.h

Remove references to ui/views/layout/layout_constants.h

This patch removes layout_constants.h and inlines them in layout_provider.cc and
chrome_layout_provider.cc. Last step of the set of changes which were around replacing
these constants with their equivalents from the layout provider.

BUG=691897
TBR=sky

Review-Url: https://codereview.chromium.org/2942453002
Cr-Commit-Position: refs/heads/master@{#479616}
Committed: https://chromium.googlesource.com/chromium/src/+/f131ea653e12fd70bcf10dc91ac5a731734e41ea

[ananta, 2017-06-13 21:34:11]

The CQ bit was checked by ananta@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 21:34:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 21:48:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 21:48:32]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ananta, 2017-06-13 22:20:39]

The CQ bit was checked by ananta@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 22:21:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ananta, 2017-06-13 23:01:45]

ananta@chromium.org changed reviewers:
+ pkasting@chromium.org

[Peter Kasting, 2017-06-13 23:33:35]

LGTM

https://codereview.chromium.org/2942453002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/harmony/chrome_layout_provider.cc (right):

https://codereview.chromium.org/2942453002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/harmony/chrome_layout_provider.cc:16: constexpr int
kMinimumButtonWidth = 48;
I would inline these directly into their single uses below.

I like named constants, but the whole point of this file is basically to return
some named-by-enum constants.  Those enum values are already commented
elsewhere.  So the additional names and comments here aren't really adding
clarity IMO.

https://codereview.chromium.org/2942453002/diff/20001/ui/views/layout/layout_...
File ui/views/layout/layout_provider.cc (right):

https://codereview.chromium.org/2942453002/diff/20001/ui/views/layout/layout_...
ui/views/layout/layout_provider.cc:18: constexpr int kPanelHorizMargin = 13;
Same comment.

[commit-bot: I haz the power, 2017-06-14 00:09:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-14 00:09:30]

Dry run: This issue passed the CQ dry run.

[ananta, 2017-06-14 18:48:06]

The CQ bit was checked by ananta@chromium.org

[ananta, 2017-06-14 18:48:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2942453002/#ps60001
(title: "Remove newlines")

[ananta, 2017-06-14 18:48:11]

https://codereview.chromium.org/2942453002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/harmony/chrome_layout_provider.cc (right):

https://codereview.chromium.org/2942453002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/harmony/chrome_layout_provider.cc:16: constexpr int
kMinimumButtonWidth = 48;
On 2017/06/13 23:33:35, Peter Kasting wrote:
> I would inline these directly into their single uses below.
> 
> I like named constants, but the whole point of this file is basically to
return
> some named-by-enum constants.  Those enum values are already commented
> elsewhere.  So the additional names and comments here aren't really adding
> clarity IMO.

Done.

https://codereview.chromium.org/2942453002/diff/20001/ui/views/layout/layout_...
File ui/views/layout/layout_provider.cc (right):

https://codereview.chromium.org/2942453002/diff/20001/ui/views/layout/layout_...
ui/views/layout/layout_provider.cc:18: constexpr int kPanelHorizMargin = 13;
On 2017/06/13 23:33:35, Peter Kasting wrote:
> Same comment.

Done.

[commit-bot: I haz the power, 2017-06-14 18:48:49]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-14 18:52:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-14 18:52:17]

Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[ananta, 2017-06-15 02:55:12]

The CQ bit was checked by ananta@chromium.org

[ananta, 2017-06-15 02:55:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2942453002/#ps80001
(title: "Rebase to tip")

[commit-bot: I haz the power, 2017-06-15 02:55:24]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-15 03:01:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-15 03:01:44]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[ananta, 2017-06-15 03:06:31]

Description was changed from

==========
Remove references to ui/views/layout/layout_constants.h

This patch removes layout_constants.h and inlines them in layout_provider.cc and
chrome_layout_provider.cc. Last step of the set of changes which were around
replacing
these constants with their equivalents from the layout provider.

BUG=691897
==========

to

==========
Remove references to ui/views/layout/layout_constants.h

This patch removes layout_constants.h and inlines them in layout_provider.cc and
chrome_layout_provider.cc. Last step of the set of changes which were around
replacing
these constants with their equivalents from the layout provider.

BUG=691897
TBR=sky
==========

[ananta, 2017-06-15 03:06:49]

ananta@chromium.org changed reviewers:
+ sky@chromium.org

[ananta, 2017-06-15 03:07:14]

+sky for ui/views owners. TBR'ing as this is a simple enough change

[ananta, 2017-06-15 03:07:23]

The CQ bit was checked by ananta@chromium.org

[commit-bot: I haz the power, 2017-06-15 03:07:35]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-15 04:55:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-15 04:55:21]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ananta, 2017-06-15 05:03:44]

The CQ bit was checked by ananta@chromium.org

[commit-bot: I haz the power, 2017-06-15 05:03:58]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-15 06:03:16]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1497503024044320,
"parent_rev": "36f87e2389e738d2b6690115d7c212e24ad053e6", "commit_rev":
"f131ea653e12fd70bcf10dc91ac5a731734e41ea"}

[commit-bot: I haz the power, 2017-06-15 06:03:28]

Description was changed from

==========
Remove references to ui/views/layout/layout_constants.h

This patch removes layout_constants.h and inlines them in layout_provider.cc and
chrome_layout_provider.cc. Last step of the set of changes which were around
replacing
these constants with their equivalents from the layout provider.

BUG=691897
TBR=sky
==========

to

==========
Remove references to ui/views/layout/layout_constants.h

This patch removes layout_constants.h and inlines them in layout_provider.cc and
chrome_layout_provider.cc. Last step of the set of changes which were around
replacing
these constants with their equivalents from the layout provider.

BUG=691897
TBR=sky

Review-Url: https://codereview.chromium.org/2942453002
Cr-Commit-Position: refs/heads/master@{#479616}
Committed:
https://chromium.googlesource.com/chromium/src/+/f131ea653e12fd70bcf10dc91ac5...
==========

[commit-bot: I haz the power, 2017-06-15 06:03:30]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/f131ea653e12fd70bcf10dc91ac5...

[sky, 2017-06-19 16:23:23]

Yay! LGTM