Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2942423002:
Adds us(intl_pc) IME to xkb extension. (Closed)
|
Created:
3 years, 6 months ago by wuyingbing1 Modified:
3 years, 5 months ago CC:
chromium-reviews, alemate+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdds us(intl_pc) IME to xkb extension.
BUG=718368
Review-Url: https://codereview.chromium.org/2942423002
Cr-Commit-Position: refs/heads/master@{#483927}
Committed: https://chromium.googlesource.com/chromium/src/+/45abfe24b9fb22f2ca0bcc99c8d45fb5f4df003f
Patch Set 1 #Patch Set 2 : Revert "The clean up Cl after https://codereview.chromium.org/2898873002/" #Patch Set 3 : Adds us(intl_pc) IME to xkb extension. #
Total comments: 2
Patch Set 4 : Adds us(intl_pc) IME to xkb extension. #Messages
Total messages: 21 (11 generated)
Description was changed from ========== Adds us(intl_pc) IME to xkb extension. BUG:chromium:718368 The clean up Cl after https://codereview.chromium.org/2898873002/ BUG=709360 ========== to ========== Adds us(intl_pc) IME to xkb extension. BUG:chromium:718368 The clean up Cl after https://codereview.chromium.org/2898873002/ BUG=709360 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Adds us(intl_pc) IME to xkb extension. BUG:chromium:718368 The clean up Cl after https://codereview.chromium.org/2898873002/ BUG=709360 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Adds us(intl_pc) IME to xkb extension. BUG:chromium:718368 The clean up Cl after https://codereview.chromium.org/2898873002/ BUG=709360 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
wuyingbing@chromium.org changed reviewers: + shuchen@chromium.org
https://codereview.chromium.org/2942423002/diff/40001/chrome/browser/resource... File chrome/browser/resources/chromeos/input_method/google_xkb_manifest.json (right): https://codereview.chromium.org/2942423002/diff/40001/chrome/browser/resource... chrome/browser/resources/chromeos/input_method/google_xkb_manifest.json:125: "en-US" We need to at first confirm which languages need the intl_pc behavior. I recall pt-BR needs it. https://codereview.chromium.org/2942423002/diff/40001/chrome/browser/resource... chrome/browser/resources/chromeos/input_method/google_xkb_manifest.json:128: "us(intl)" should be us(intl_pc)
On 2017/06/19 07:15:26, Shu Chen wrote: > https://codereview.chromium.org/2942423002/diff/40001/chrome/browser/resource... > File chrome/browser/resources/chromeos/input_method/google_xkb_manifest.json > (right): > > https://codereview.chromium.org/2942423002/diff/40001/chrome/browser/resource... > chrome/browser/resources/chromeos/input_method/google_xkb_manifest.json:125: > "en-US" > We need to at first confirm which languages need the intl_pc behavior. > I recall pt-BR needs it. DONE > > https://codereview.chromium.org/2942423002/diff/40001/chrome/browser/resource... > chrome/browser/resources/chromeos/input_method/google_xkb_manifest.json:128: > "us(intl)" > should be us(intl_pc) DONE
The CQ bit was checked by wuyingbing@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
lgtm
Description was changed from ========== Adds us(intl_pc) IME to xkb extension. BUG:chromium:718368 The clean up Cl after https://codereview.chromium.org/2898873002/ BUG=709360 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Adds us(intl_pc) IME to xkb extension. BUG=718368 ==========
wuyingbing@chromium.org changed reviewers: + sky@chromium.org
wuyingbing@chromium.org changed reviewers: + derat@chromium.org - sky@chromium.org
Ping~ Hi Daniel, I add sky as reviewer several days ago, but he is OOO now. So adds you as reviewer.
Ping~ Hi Daniel, I add sky as reviewer several days ago, but he is OOO now. So adds you as reviewer.
lgtm
The CQ bit was checked by wuyingbing@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1499047919321470,
"parent_rev": "97796fd23c6dede6e98f2db61dea0d8e6f8aec9a", "commit_rev":
"45abfe24b9fb22f2ca0bcc99c8d45fb5f4df003f"}
Message was sent while issue was closed.
Description was changed from ========== Adds us(intl_pc) IME to xkb extension. BUG=718368 ========== to ========== Adds us(intl_pc) IME to xkb extension. BUG=718368 Review-Url: https://codereview.chromium.org/2942423002 Cr-Commit-Position: refs/heads/master@{#483927} Committed: https://chromium.googlesource.com/chromium/src/+/45abfe24b9fb22f2ca0bcc99c8d4... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/45abfe24b9fb22f2ca0bcc99c8d4... |
