Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2942163003: Pass user gesture flag when opening a new tab on Android. (Closed)

Created:
3 years, 6 months ago by troyhildebrandt
Modified:
3 years, 6 months ago
Reviewers:
Ted C, Maria
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass user gesture flag when opening a new tab on Android. What was thought to be a bug related to rel=noopener turned out to be a bug with opening new tabs after all (oops.) User gestures were not being passed through via LoadURLParams on Android, which causes issues with launching apps when necessary via links with target=_blank. BUG=729187, 728346 Review-Url: https://codereview.chromium.org/2942163003 Cr-Commit-Position: refs/heads/master@{#480124} Committed: https://chromium.googlesource.com/chromium/src/+/b0d04772edfcaf49e8bfc909f8ed1596e8d46184

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M components/web_contents_delegate_android/web_contents_delegate_android.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
troyhildebrandt
3 years, 6 months ago (2017-06-16 17:39:48 UTC) #3
Maria
lgtm
3 years, 6 months ago (2017-06-16 18:05:08 UTC) #5
troyhildebrandt
3 years, 6 months ago (2017-06-16 18:26:09 UTC) #8
Ted C
lgtm
3 years, 6 months ago (2017-06-16 18:28:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2942163003/20001
3 years, 6 months ago (2017-06-16 18:51:12 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-06-16 19:38:54 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b0d04772edfcaf49e8bfc909f8ed...

Powered by Google App Engine
This is Rietveld 408576698