Enable top level inference of instance property gets/sets.

Enable top level inference of instance property gets/sets.

To facilitate experimentation, I've left the old code in place, but
disabled it using a const bool `fullTopLevelInference`.  The old code
can be re-enabled by setting this bool to `false`.  Once we are sure
that we want to proceed with this approach, we can remove the old
code.

I believe that with this change, all expressions that can be type
inferred inside a method body can now be type inferred at top level,
provided that there are no circular dependencies.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/953399512a5611ff103c7ef1f019e429d1a07d58

[Paul Berry, 2017-06-16 03:10:38]

paulberry@google.com changed reviewers:
+ ahe@google.com, danrubel@google.com, scheglov@google.com, sigmund@google.com

[Paul Berry, 2017-06-16 03:10:39]

Including a lot of reviewers since I'm not sure who will be available next.  I
only need an lgtm from one of you.

[Siggi Cherem (dart-lang), 2017-06-16 03:40:03]

lgtm, neat!

https://codereview.chromium.org/2942153002/diff/1/pkg/front_end/testcases/inf...
File pkg/front_end/testcases/inference/infer_assign_to_ref.dart (left):

https://codereview.chromium.org/2942153002/diff/1/pkg/front_end/testcases/inf...
pkg/front_end/testcases/inference/infer_assign_to_ref.dart:14:
(/*error:TOP_LEVEL_UNSUPPORTED*/ a. /*@target=A::f*/ f = 1);
I wonder if there is value in also keeping the old tests around by passing
another flag to the test framework. For instance, have
testedFeatures=inference_old or =inference_new to toggle the flags and continue
to test the old behavior until it gets deleted.

[Paul Berry, 2017-06-16 03:44:09]

https://codereview.chromium.org/2942153002/diff/1/pkg/front_end/testcases/inf...
File pkg/front_end/testcases/inference/infer_assign_to_ref.dart (left):

https://codereview.chromium.org/2942153002/diff/1/pkg/front_end/testcases/inf...
pkg/front_end/testcases/inference/infer_assign_to_ref.dart:14:
(/*error:TOP_LEVEL_UNSUPPORTED*/ a. /*@target=A::f*/ f = 1);
On 2017/06/16 03:40:03, Siggi Cherem (dart-lang) wrote:
> I wonder if there is value in also keeping the old tests around by passing
> another flag to the test framework. For instance, have
> testedFeatures=inference_old or =inference_new to toggle the flags and
continue
> to test the old behavior until it gets deleted.

Acknowledged.

[Paul Berry, 2017-06-16 03:51:24]

Description was changed from

==========
Enable top level inference of instance property gets/sets.

To facilitate experimentation, I've left the old code in place, but
disabled it using a const bool `fullTopLevelInference`.  The old code
can be re-enabled by setting this bool to `false`.  Once we are sure
that we want to proceed with this approach, we can remove the old
code.

I believe that with this change, all expressions that can be type
inferred inside a method body can now be type inferred at top level,
provided that there are no circular dependencies.
==========

to

==========
Enable top level inference of instance property gets/sets.

To facilitate experimentation, I've left the old code in place, but
disabled it using a const bool `fullTopLevelInference`.  The old code
can be re-enabled by setting this bool to `false`.  Once we are sure
that we want to proceed with this approach, we can remove the old
code.

I believe that with this change, all expressions that can be type
inferred inside a method body can now be type inferred at top level,
provided that there are no circular dependencies.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/953399512a5611ff103c7ef1f019e429d1a07d58
==========

[Paul Berry, 2017-06-16 03:51:26]

Committed patchset #1 (id:1) manually as
953399512a5611ff103c7ef1f019e429d1a07d58 (presubmit successful).