Break LayoutObject dependency for NinePieceImagePainter

Break LayoutObject dependency for NinePieceImagePainter

Break the dependency on LayoutObject for NinePieceImage painting and for
border painting by updating NinePieceImagePainter to instead take a Node
and a ImageResourceObserver reference. Also moves border painting to the
BoxPainterBase class as border painting can now be shared with LayoutNG.

R=pdr@chromium.org
BUG=714962
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2942123002
Cr-Commit-Position: refs/heads/master@{#480948}
Committed: https://chromium.googlesource.com/chromium/src/+/cfbb107861720c74448855869af827e844728054

[eae, 2017-06-16 01:10:57]

Description was changed from

==========
Break LayoutObject dependency for NinePieceImagePainter

Break the dependency on LayoutObject for NinePieceImage painting and for
border painting by updating NinePieceImagePainter to instead take a Node
and a ImageResourceObserver reference. Also moves border painting to the
BoxPainterBase class as border painting can now be shared with LayoutNG.

R=pdr@chromium.org
BUG=714962
==========

to

==========
Break LayoutObject dependency for NinePieceImagePainter

Break the dependency on LayoutObject for NinePieceImage painting and for
border painting by updating NinePieceImagePainter to instead take a Node
and a ImageResourceObserver reference. Also moves border painting to the
BoxPainterBase class as border painting can now be shared with LayoutNG.

R=pdr@chromium.org
BUG=714962
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[eae, 2017-06-16 01:11:04]

The CQ bit was checked by eae@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-16 01:11:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 01:13:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-16 01:13:44]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[eae, 2017-06-16 01:15:21]

(depends on the other two linked CL, hence the unhappy bots)

[pdr., 2017-06-19 17:30:21]

On 2017/06/16 at 01:15:21, eae wrote:
> (depends on the other two linked CL, hence the unhappy bots)

LGTM

[eae, 2017-06-19 18:02:33]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2017-06-19 18:02:45]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-19 18:05:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-19 18:05:35]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[eae, 2017-06-19 18:26:17]

The CQ bit was checked by eae@chromium.org

[eae, 2017-06-19 18:26:18]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2942123002/#ps20001
(title: "Rebase w/HEAD")

[commit-bot: I haz the power, 2017-06-19 18:26:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-19 19:53:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-19 19:53:18]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[eae, 2017-06-19 21:26:49]

The CQ bit was checked by eae@chromium.org

[eae, 2017-06-19 21:26:50]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2942123002/#ps40001
(title: "Rebase w/HEAD")

[commit-bot: I haz the power, 2017-06-19 21:27:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-19 22:42:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-19 22:42:45]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[pdr., 2017-06-19 22:45:02]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2017-06-19 22:45:34]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eae, 2017-06-19 23:58:13]

The CQ bit was unchecked by eae@chromium.org

[eae, 2017-06-20 15:35:22]

The CQ bit was checked by eae@chromium.org

[eae, 2017-06-20 15:35:22]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2942123002/#ps60001
(title: "Pass document explicitly")

[commit-bot: I haz the power, 2017-06-20 15:35:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-20 17:29:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-20 17:29:32]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[eae, 2017-06-20 17:58:16]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2017-06-20 17:58:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-20 20:46:16]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1497981496357140,
"parent_rev": "9262aba8fec57bed8ce2256574e0e38ad53ae917", "commit_rev":
"cfbb107861720c74448855869af827e844728054"}

[commit-bot: I haz the power, 2017-06-20 20:46:29]

Description was changed from

==========
Break LayoutObject dependency for NinePieceImagePainter

Break the dependency on LayoutObject for NinePieceImage painting and for
border painting by updating NinePieceImagePainter to instead take a Node
and a ImageResourceObserver reference. Also moves border painting to the
BoxPainterBase class as border painting can now be shared with LayoutNG.

R=pdr@chromium.org
BUG=714962
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Break LayoutObject dependency for NinePieceImagePainter

Break the dependency on LayoutObject for NinePieceImage painting and for
border painting by updating NinePieceImagePainter to instead take a Node
and a ImageResourceObserver reference. Also moves border painting to the
BoxPainterBase class as border painting can now be shared with LayoutNG.

R=pdr@chromium.org
BUG=714962
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2942123002
Cr-Commit-Position: refs/heads/master@{#480948}
Committed:
https://chromium.googlesource.com/chromium/src/+/cfbb107861720c74448855869af8...
==========

[commit-bot: I haz the power, 2017-06-20 20:46:31]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/cfbb107861720c74448855869af8...