Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Issue 2942113003: Specify the full type on a Pair constructor in ChromeDownloadDelegate.java . (Closed)

Created:
3 years, 6 months ago by lgarron
Modified:
3 years, 6 months ago
Reviewers:
qinmin
CC:
agrieve+watch_chromium.org, chromium-reviews, dtrainor+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Specify the full type on a Pair constructor in ChromeDownloadDelegate.java . This prevents two warnings during Android compilation (unchecked call, unchecked conversion). BUG= Review-Url: https://codereview.chromium.org/2942113003 Cr-Commit-Position: refs/heads/master@{#479963} Committed: https://chromium.googlesource.com/chromium/src/+/3b25ca99578bd381854851fb98007fa56d380729

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
lgarron
qinmin@, could you review?
3 years, 6 months ago (2017-06-16 00:33:27 UTC) #2
qinmin
lgtm
3 years, 6 months ago (2017-06-16 04:40:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2942113003/1
3 years, 6 months ago (2017-06-16 04:43:42 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-16 05:55:24 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3b25ca99578bd381854851fb9800...

Powered by Google App Engine
This is Rietveld 408576698