Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1434)

Issue 2942103002: Fix failing NavigationManagerUtil test that wasn't being run. (Closed)

Created:
3 years, 6 months ago by kkhorimoto
Modified:
3 years, 6 months ago
CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix failing NavigationManagerUtil test that wasn't being run. This test was added to a suite that was not properly connected to the waterfall, and has been failing silently. BUG=733658 Review-Url: https://codereview.chromium.org/2942103002 Cr-Commit-Position: refs/heads/master@{#481336} Committed: https://chromium.googlesource.com/chromium/src/+/d3cb2e604616779b44a1f900dfaa50aa565b23a5

Patch Set 1 #

Total comments: 4

Patch Set 2 : rebase, moved fake #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -5 lines) Patch
M ios/web/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ios/web/navigation/navigation_manager_util_unittest.mm View 1 2 6 chunks +14 lines, -5 lines 0 comments Download
M ios/web/test/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
A ios/web/test/fakes/BUILD.gn View 1 1 chunk +17 lines, -0 lines 0 comments Download
A ios/web/test/fakes/test_navigation_manager_delegate.h View 1 1 chunk +26 lines, -0 lines 0 comments Download
A ios/web/test/fakes/test_navigation_manager_delegate.mm View 1 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
kkhorimoto
Test fixes for broken unittest target. Sylvain, are further steps required to get these tests ...
3 years, 6 months ago (2017-06-16 00:01:20 UTC) #2
Eugene But (OOO till 7-30)
Thanks for fixing the text! lgtm https://codereview.chromium.org/2942103002/diff/1/ios/web/navigation/navigation_manager_util_unittest.mm File ios/web/navigation/navigation_manager_util_unittest.mm (right): https://codereview.chromium.org/2942103002/diff/1/ios/web/navigation/navigation_manager_util_unittest.mm#newcode22 ios/web/navigation/navigation_manager_util_unittest.mm:22: class UtilTestNavigationManagerDelegate : ...
3 years, 6 months ago (2017-06-16 03:41:06 UTC) #3
sdefresne
On 2017/06/16 00:01:20, kkhorimoto_ wrote: > Test fixes for broken unittest target. Sylvain, are further ...
3 years, 6 months ago (2017-06-16 13:02:49 UTC) #4
sdefresne
lgtm https://codereview.chromium.org/2942103002/diff/1/ios/web/navigation/navigation_manager_util_unittest.mm File ios/web/navigation/navigation_manager_util_unittest.mm (right): https://codereview.chromium.org/2942103002/diff/1/ios/web/navigation/navigation_manager_util_unittest.mm#newcode55 ios/web/navigation/navigation_manager_util_unittest.mm:55: TEST_F(NavigationManagerUtilTest, GetCommittedItemWithUniqueID) { Once you rebase, you'll have ...
3 years, 6 months ago (2017-06-16 13:39:43 UTC) #5
kkhorimoto
rebase, moved fake
3 years, 6 months ago (2017-06-21 19:21:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2942103002/20001
3 years, 6 months ago (2017-06-21 19:21:44 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/242677)
3 years, 6 months ago (2017-06-21 19:24:53 UTC) #11
kkhorimoto
rebase
3 years, 6 months ago (2017-06-21 20:49:51 UTC) #12
kkhorimoto
https://codereview.chromium.org/2942103002/diff/1/ios/web/navigation/navigation_manager_util_unittest.mm File ios/web/navigation/navigation_manager_util_unittest.mm (right): https://codereview.chromium.org/2942103002/diff/1/ios/web/navigation/navigation_manager_util_unittest.mm#newcode22 ios/web/navigation/navigation_manager_util_unittest.mm:22: class UtilTestNavigationManagerDelegate : public NavigationManagerDelegate { On 2017/06/16 03:41:06, ...
3 years, 6 months ago (2017-06-21 20:50:18 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2942103002/40001
3 years, 6 months ago (2017-06-21 20:50:49 UTC) #16
commit-bot: I haz the power
3 years, 6 months ago (2017-06-21 22:40:40 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d3cb2e604616779b44a1f900dfaa...

Powered by Google App Engine
This is Rietveld 408576698