Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(966)

Unified Diff: tests/standalone/io/skipping_dart2js_compilations_test.dart

Issue 2942083002: Fix static errors (and hints) in test. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/io/skipping_dart2js_compilations_test.dart
diff --git a/tests/standalone/io/skipping_dart2js_compilations_test.dart b/tests/standalone/io/skipping_dart2js_compilations_test.dart
index b6e5c0e4c95ed2d5b94ece3cb51d57bda7eea9a1..1fd97509dfede1b822bce489e6d2f4d3ecf954b5 100644
--- a/tests/standalone/io/skipping_dart2js_compilations_test.dart
+++ b/tests/standalone/io/skipping_dart2js_compilations_test.dart
@@ -17,11 +17,10 @@
*/
import 'package:expect/expect.dart';
-import 'package:path/path.dart';
import 'dart:async';
import 'dart:io';
import '../../../tools/testing/dart/command.dart';
-import '../../../tools/testing/dart/options.dart' as options;
+import '../../../tools/testing/dart/command_output.dart';
import '../../../tools/testing/dart/path.dart';
import '../../../tools/testing/dart/test_runner.dart' as runner;
import '../../../tools/testing/dart/utils.dart';
@@ -128,12 +127,11 @@ class FileUtils {
class CommandCompletedHandler {
FileUtils fileUtils;
- DateTime _expectedTimestamp;
bool _shouldHaveRun;
CommandCompletedHandler(FileUtils this.fileUtils, bool this._shouldHaveRun);
- void processCompletedTest(runner.CommandOutput output) {
+ void processCompletedTest(CommandOutput output) {
Expect.isTrue(output.exitCode == 0);
Expect.isTrue(output.stderr.length == 0);
if (_shouldHaveRun) {
@@ -148,7 +146,6 @@ class CommandCompletedHandler {
}
Command makeCompilationCommand(String testName, FileUtils fileUtils) {
- var config = new options.OptionsParser().parse(['--timeout', '2'])[0];
var createFileScript = Platform.script
.resolve('skipping_dart2js_compilations_helper.dart')
.toFilePath();
@@ -217,7 +214,7 @@ void main() {
var completedHandler = new CommandCompletedHandler(fileUtils, shouldRun);
var command = makeCompilationCommand(name, fileUtils);
var process = new runner.RunningProcess(command, 60);
- return process.run().then((runner.CommandOutput output) {
+ return process.run().then((CommandOutput output) {
completedHandler.processCompletedTest(output);
});
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698