Fix static errors (and hints) in test.

tests/standalone/io/skipping_dart2js_compilations_test.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // OtherResources=skipping_dart2js_compilations_helper.dart
 
 /*
  * This test makes sure that the "skipping Dart2Js compilations if the output is
  * already up to date" feature does work as it should.
  * Therefore this test ensures that compilations are only skipped if the last
  * modified date of the output of a dart2js compilation is newer than
  *   - the dart application to compile (including it's dependencies)
  *   - the dart2js snapshot
  * Furtheremore it ensure that a compilations is not skipped if any of the
  * necessary files could not be found (dart2js snapshots, previous dart2js
  * output (+deps file), dart application)
  */
 
 import 'package:expect/expect.dart';
-import 'package:path/path.dart';
 import 'dart:async';
 import 'dart:io';
 import '../../../tools/testing/dart/command.dart';
-import '../../../tools/testing/dart/options.dart' as options;
+import '../../../tools/testing/dart/command_output.dart';
 import '../../../tools/testing/dart/path.dart';
 import '../../../tools/testing/dart/test_runner.dart' as runner;
 import '../../../tools/testing/dart/utils.dart';
 
 /**
  * This class is reponsible for setting up the files necessary for this test
  * as well as touching a file.
  */
 class FileUtils {
   Directory tempDir;
@@ skipping 86 matching lines @@
 
   File _createFile(Path path) {
     var file = new File(path.toNativePath());
     file.createSync();
     return file;
   }
 }
 
 class CommandCompletedHandler {
   FileUtils fileUtils;
-  DateTime _expectedTimestamp;
   bool _shouldHaveRun;
 
   CommandCompletedHandler(FileUtils this.fileUtils, bool this._shouldHaveRun);
 
-  void processCompletedTest(runner.CommandOutput output) {
+  void processCompletedTest(CommandOutput output) {
     Expect.isTrue(output.exitCode == 0);
     Expect.isTrue(output.stderr.length == 0);
     if (_shouldHaveRun) {
       Expect.isTrue(output.stdout.length == 0);
       Expect.isTrue(
           new File(fileUtils.scriptOutputPath.toNativePath()).existsSync());
     } else {
       Expect.isFalse(
           new File(fileUtils.scriptOutputPath.toNativePath()).existsSync());
     }
   }
 }
 
 Command makeCompilationCommand(String testName, FileUtils fileUtils) {
-  var config = new options.OptionsParser().parse(['--timeout', '2'])[0];
   var createFileScript = Platform.script
       .resolve('skipping_dart2js_compilations_helper.dart')
       .toFilePath();
   var executable = Platform.executable;
   var arguments = [createFileScript, fileUtils.scriptOutputPath.toNativePath()];
   var bootstrapDeps = [Uri.parse("file://${fileUtils.testSnapshotFilePath}")];
   return Command.compilation('dart2js', fileUtils.testJsFilePath.toNativePath(),
       false, bootstrapDeps, executable, arguments, {});
 }
 
@@ skipping 48 matching lines @@
 
   void touchFilesAndRunTests() {
     fs_notUpToDate_snapshot.touchFile(fs_notUpToDate_snapshot.testSnapshot);
     fs_notUpToDate_dart.touchFile(fs_notUpToDate_dart.testDart);
     fs_upToDate.touchFile(fs_upToDate.testJs);
 
     Future runTest(String name, FileUtils fileUtils, bool shouldRun) {
       var completedHandler = new CommandCompletedHandler(fileUtils, shouldRun);
       var command = makeCompilationCommand(name, fileUtils);
       var process = new runner.RunningProcess(command, 60);
-      return process.run().then((runner.CommandOutput output) {
+      return process.run().then((CommandOutput output) {
         completedHandler.processCompletedTest(output);
       });
     }
 
     // We run the tests in sequence, so that if one of them failes we clean up
     // everything and throw.
     runTest("fs_noTestJs", fs_noTestJs, true).then((_) {
       return runTest("fs_noTestJsDeps", fs_noTestJsDeps, true);
     }).then((_) {
       return runTest("fs_noTestDart", fs_noTestDart, true);
@@ skipping 13 matching lines @@
       throw error;
     }).then((_) {
       cleanup();
     });
   }
 
   // We need to wait some time to make sure that the files we 'touch' get a
   // bigger timestamp than the old ones
   new Timer(new Duration(seconds: 1), touchFilesAndRunTests);
 }