Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 2942043003: Minor fixes to the Chrome Cleanup WebUI (Closed)

Created:
3 years, 6 months ago by proberge
Modified:
3 years, 6 months ago
Reviewers:
srahim, alito, tommycli
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, dbeam+watch-settings_chromium.org, srahim+watch_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Minor fixes to the Chrome Cleanup WebUI Update an unclear string (to finish what?) Make the action button blue Fix a typo in the handler to allow the non-reboot dismiss button to work. BUG=690020 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2942043003 Cr-Commit-Position: refs/heads/master@{#480442} Committed: https://chromium.googlesource.com/chromium/src/+/8b5035694768d164e3992856d3901664dd9b8ce3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/chrome_cleanup_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
proberge
+alito could you take a look? +srahim as fyi for string change, no review needed ...
3 years, 6 months ago (2017-06-15 20:36:29 UTC) #3
alito
lgtm
3 years, 6 months ago (2017-06-16 03:27:39 UTC) #4
proberge
++tommycli for webui OWNERS
3 years, 6 months ago (2017-06-16 13:45:14 UTC) #6
tommycli
lgtm
3 years, 6 months ago (2017-06-17 01:11:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2942043003/1
3 years, 6 months ago (2017-06-19 13:32:42 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-19 15:17:53 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8b5035694768d164e3992856d390...

Powered by Google App Engine
This is Rietveld 408576698