Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2942023003: [Extensions Bindings] Correctly create the sendMessage webview event (Closed)

Created:
3 years, 6 months ago by Devlin
Modified:
3 years, 6 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions Bindings] Correctly create the sendMessage webview event crrev.com/3e46aa6ced2554cd07a7cc9aad1ec98b384dff07 added logic for web_view_events.js with native bindings, but created a declarative event for the onMessage event, which should actually have been a vanilla event. Update the bindings. BUG=653596 TEST=browser_tests --gtest_filter=WebViewTests/WebViewTest.Shim_TestDeclarativeWebRequestAPISendMessage/0 --native-crx-bindings=1 Review-Url: https://codereview.chromium.org/2942023003 Cr-Commit-Position: refs/heads/master@{#479782} Committed: https://chromium.googlesource.com/chromium/src/+/a090c7e903539a6efa8714926cf0a2ca0c9d1314

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M extensions/renderer/resources/guest_view/web_view/web_view_events.js View 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Devlin
Whoops :/ Luckily this was only with native bindings, since the path for js-based events ...
3 years, 6 months ago (2017-06-15 18:19:57 UTC) #7
lazyboy
lgtm
3 years, 6 months ago (2017-06-15 18:26:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2942023003/1
3 years, 6 months ago (2017-06-15 18:28:20 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-15 19:30:52 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a090c7e903539a6efa8714926cf0...

Powered by Google App Engine
This is Rietveld 408576698