Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Issue 2942003002: [ios] Fix "return foo = nil" introduced by ARC conversion tools. (Closed)

Created:
3 years, 6 months ago by marq (ping after 24h)
Modified:
3 years, 6 months ago
Reviewers:
stkhapugin, msarda
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, vabr+watchlistpasswordmanager_chromium.org, noyau+watch_chromium.org, marq+watch_chromium.org, gcasto+watchlist_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Fix "return foo = nil" introduced by ARC conversion tools. This CL fixes several cases where views were returned as nil as a result of ARC migration tools. BUG= Review-Url: https://codereview.chromium.org/2942003002 Cr-Commit-Position: refs/heads/master@{#479690} Committed: https://chromium.googlesource.com/chromium/src/+/e5a9cd7d13c77e6599a35aaaf62451d1925d7d8b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M ios/chrome/browser/passwords/password_generation_prompt_view.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/authentication/signin_account_selector_view_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/settings/sync_encryption_passphrase_collection_view_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_cell.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
marq (ping after 24h)
msarda@: FYI
3 years, 6 months ago (2017-06-15 13:42:15 UTC) #2
msarda
lgtm
3 years, 6 months ago (2017-06-15 13:44:38 UTC) #3
msarda
Thank you for fixing this.
3 years, 6 months ago (2017-06-15 13:44:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2942003002/1
3 years, 6 months ago (2017-06-15 13:49:05 UTC) #6
stkhapugin
lgtm
3 years, 6 months ago (2017-06-15 13:57:52 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-06-15 14:01:13 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e5a9cd7d13c77e6599a35aaaf624...

Powered by Google App Engine
This is Rietveld 408576698