Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2941953002: Add switches for language detection and translation logging. (Closed)

Created:
3 years, 6 months ago by renjieliu1
Modified:
3 years, 6 months ago
Reviewers:
napper, groby-ooo-7-16
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add switches for language detection and translation logging. Apply switches as previosuly discussed so we easily turn off language detection logging or translation logging if something goes wrong. BUG=728491, 722679 Review-Url: https://codereview.chromium.org/2941953002 Cr-Commit-Position: refs/heads/master@{#481054} Committed: https://chromium.googlesource.com/chromium/src/+/106a571ac7652839571550ae6738086a4e787c31

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M chrome/browser/translate/chrome_translate_client.cc View 5 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/translate/chrome_translate_client_unittest.cc View 1 3 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
renjieliu1
3 years, 6 months ago (2017-06-16 02:25:54 UTC) #9
napper
lgtm
3 years, 6 months ago (2017-06-18 21:47:56 UTC) #12
renjieliu1
3 years, 6 months ago (2017-06-19 00:11:39 UTC) #14
groby-ooo-7-16
lgtm
3 years, 6 months ago (2017-06-20 21:14:12 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2941953002/20001
3 years, 6 months ago (2017-06-20 23:43:01 UTC) #17
commit-bot: I haz the power
3 years, 6 months ago (2017-06-21 01:04:06 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/106a571ac7652839571550ae6738...

Powered by Google App Engine
This is Rietveld 408576698