Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 2941913002: WebVR: Fix missing sample collection for prediction timing (Closed)

Created:
3 years, 6 months ago by klausw
Modified:
3 years, 6 months ago
Reviewers:
mthiesse, bajones
CC:
chromium-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

WebVR: Fix missing sample collection for prediction timing The pose latency prediction was not collecting data samples due to an incomplete cherry-pick, so it was stuck using the fallback values of 16ms each for JS and render latency. BUG=733449 Review-Url: https://codereview.chromium.org/2941913002 Cr-Commit-Position: refs/heads/master@{#479565} Committed: https://chromium.googlesource.com/chromium/src/+/f1324c8312f7c716474ef43c9b3de89f1095d694

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M chrome/browser/android/vr_shell/vr_shell_gl.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_gl.cc View 1 4 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
klausw
3 years, 6 months ago (2017-06-15 00:16:13 UTC) #2
mthiesse
lgtm
3 years, 6 months ago (2017-06-15 00:25:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2941913002/20001
3 years, 6 months ago (2017-06-15 00:26:47 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-15 01:11:46 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f1324c8312f7c716474ef43c9b3d...

Powered by Google App Engine
This is Rietveld 408576698