Add flags and skeleton for profiling process.

Add flags and skeleton for profiling process.

This will be used for the out-of-process heap profiler. Currently it just checks for the new process type and returns success.

BUG=733336
Review-Url: https://codereview.chromium.org/2941823002
Cr-Commit-Position: refs/heads/master@{#479572}
Committed: https://chromium.googlesource.com/chromium/src/+/4a5810c3e6b5834a2609bf5935c0d31506f813bf

[brettw, 2017-06-14 17:57:29]

brettw@chromium.org changed reviewers:
+ borisv@chromium.org

[brettw, 2017-06-14 17:59:50]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-14 18:00:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-14 19:00:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-14 19:00:34]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[brettw, 2017-06-14 19:08:09]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-14 19:08:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-14 21:40:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-14 21:40:02]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2017-06-14 21:55:01]

Fix header checking

[brettw, 2017-06-14 21:59:45]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-14 22:00:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Boris Vidolov, 2017-06-14 22:02:28]

Thanks, Brett. Just one comment - the folder and the files are called
"profiling", which typically expands beyond memory profiling. I am wondering if
we plan to implement multiple profiling types here.

https://codereview.chromium.org/2941823002/diff/20001/chrome/profiling/README.md
File chrome/profiling/README.md (right):

https://codereview.chromium.org/2941823002/diff/20001/chrome/profiling/README...
chrome/profiling/README.md:3: This directory contains the code for the
"profiling" process.
This assumes general resource profiling, not just memory profiling. Do we plan
to expand the sample profiler to other events?

[brettw, 2017-06-14 22:13:34]

On 2017/06/14 22:02:28, Boris Vidolov wrote:
> Thanks, Brett. Just one comment - the folder and the files are called
> "profiling", which typically expands beyond memory profiling. I am wondering
if
> we plan to implement multiple profiling types here.
> 
>
https://codereview.chromium.org/2941823002/diff/20001/chrome/profiling/README.md
> File chrome/profiling/README.md (right):
> 
>
https://codereview.chromium.org/2941823002/diff/20001/chrome/profiling/README...
> chrome/profiling/README.md:3: This directory contains the code for the
> "profiling" process.
> This assumes general resource profiling, not just memory profiling. Do we plan
> to expand the sample profiler to other events?

Yes, I did this because there are discussions about moving more types of tracing
and profiling out of process.

[brettw, 2017-06-14 22:14:57]

The CQ bit was unchecked by brettw@chromium.org

[brettw, 2017-06-14 22:15:02]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2017-06-14 22:15:21]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-14 22:15:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-14 22:15:22]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[Boris Vidolov, 2017-06-14 22:26:24]

lgtm

Thanks, Brett

[brettw, 2017-06-14 22:26:53]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2017-06-14 22:27:21]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-14 22:27:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-14 22:27:24]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[awong, 2017-06-14 23:07:38]

ajwong@chromium.org changed reviewers:
+ ajwong@chromium.org

[awong, 2017-06-14 23:07:39]

LGTM

[brettw, 2017-06-14 23:15:26]

Fix header

[brettw, 2017-06-14 23:15:26]

The CQ bit was checked by brettw@chromium.org

[brettw, 2017-06-14 23:15:27]

The patchset sent to the CQ was uploaded after l-g-t-m from borisv@chromium.org,
ajwong@chromium.org
Link to the patchset: https://codereview.chromium.org/2941823002/#ps40001
(title: "Fix header")

[commit-bot: I haz the power, 2017-06-14 23:15:45]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-15 01:34:10]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497482126849760,
"parent_rev": "0667367bcef7b8105d76e500c80f265bbda69aed", "commit_rev":
"4a5810c3e6b5834a2609bf5935c0d31506f813bf"}

[commit-bot: I haz the power, 2017-06-15 01:34:18]

Description was changed from

==========
Add flags and skeleton for profiling process.

This will be used for the out-of-process heap profiler. Currently it just checks
for the new process type and returns success.

BUG=733336
==========

to

==========
Add flags and skeleton for profiling process.

This will be used for the out-of-process heap profiler. Currently it just checks
for the new process type and returns success.

BUG=733336

Review-Url: https://codereview.chromium.org/2941823002
Cr-Commit-Position: refs/heads/master@{#479572}
Committed:
https://chromium.googlesource.com/chromium/src/+/4a5810c3e6b5834a2609bf5935c0...
==========

[commit-bot: I haz the power, 2017-06-15 01:34:20]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/4a5810c3e6b5834a2609bf5935c0...