Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 2941743002: Revert of Deprecate native and extension notification delegates. (Closed)

Created:
3 years, 6 months ago by Henrik Grunell
Modified:
3 years, 6 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, awdf+watch_chromium.org, mlamouri+watch-notifications_chromium.org, jam, darin-cc_chromium.org, chromium-apps-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Deprecate native and extension notification delegates. (patchset #2 id:20001 of https://codereview.chromium.org/2928303002/ ) Reason for revert: Breaks https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20ASAN. Original issue's description: > Deprecate native and extension notification delegates. > > WebNotificationDelegate can now handle extensions and all web > notifications as a result. > > TBR=avi@chromium.org > BUG=720345 > > Review-Url: https://codereview.chromium.org/2928303002 > Cr-Commit-Position: refs/heads/master@{#479347} > Committed: https://chromium.googlesource.com/chromium/src/+/d95830c60e22fa695f0521004149caf03bcc2f77 TBR=peter@chromium.org,avi@chromium.org,miguelg@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=720345 Review-Url: https://codereview.chromium.org/2941743002 Cr-Commit-Position: refs/heads/master@{#479357} Committed: https://chromium.googlesource.com/chromium/src/+/b960aca0d0a3938b7400d508128eadf3951fc00d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+298 lines, -197 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/notifications/extension_notification_handler.h View 3 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/notifications/extension_notification_handler.cc View 2 chunks +0 lines, -43 lines 0 comments Download
M chrome/browser/extensions/api/notifications/notifications_api.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/notifications/notifications_api.cc View 5 chunks +175 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/notifications/notifications_apitest.cc View 1 chunk +0 lines, -1 line 0 comments Download
A chrome/browser/notifications/native_notification_delegate.h View 1 chunk +30 lines, -0 lines 0 comments Download
A chrome/browser/notifications/native_notification_delegate.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/notifications/non_persistent_notification_handler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/notifications/non_persistent_notification_handler.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/notifications/notification_common.h View 2 chunks +0 lines, -16 lines 0 comments Download
M chrome/browser/notifications/notification_common.cc View 2 chunks +0 lines, -60 lines 0 comments Download
M chrome/browser/notifications/notification_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/notifications/notification_display_service.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/notifications/notification_display_service.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/notifications/notification_handler.h View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/notifications/persistent_notification_handler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/notifications/persistent_notification_handler.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/notifications/platform_notification_service_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/notifications/platform_notification_service_interactive_uitest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/notifications/platform_notification_service_unittest.cc View 3 chunks +5 lines, -8 lines 0 comments Download
M chrome/browser/notifications/stub_notification_display_service.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/notifications/stub_notification_display_service.cc View 3 chunks +7 lines, -10 lines 0 comments Download
M chrome/browser/notifications/web_notification_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/notifications/web_notification_delegate.cc View 2 chunks +58 lines, -6 lines 0 comments Download
M content/test/mock_platform_notification_service.cc View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Henrik Grunell
Created Revert of Deprecate native and extension notification delegates.
3 years, 6 months ago (2017-06-14 12:32:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2941743002/1
3 years, 6 months ago (2017-06-14 12:32:10 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-06-14 12:33:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b960aca0d0a3938b7400d508128e...

Powered by Google App Engine
This is Rietveld 408576698