Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2941583003: update invalid hex digit recovery (Closed)

Created:
3 years, 6 months ago by danrubel
Modified:
3 years, 6 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

update invalid hex digit recovery * update invalid hex digit recovery for compatibility with analyzer * address comments from https://codereview.chromium.org/2915093002 R=ahe@google.com Committed: https://github.com/dart-lang/sdk/commit/f8655ca568fe2906f04e0c88c22ab438b0c5d345

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M pkg/front_end/lib/src/fasta/scanner/recover.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/test/scanner_test.dart View 10 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
3 years, 6 months ago (2017-06-14 03:16:46 UTC) #2
ahe
lgtm
3 years, 6 months ago (2017-06-14 06:43:09 UTC) #3
danrubel
3 years, 6 months ago (2017-06-14 15:18:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f8655ca568fe2906f04e0c88c22ab438b0c5d345 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698