improve fasta unterminated string recovery

improve fasta unterminated string recovery

This updates the fasta scanner
to append synthetic closing quotes to unterminated strings.

Rework of https://codereview.chromium.org/2912693002/

R=ahe@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/b61f9f2343e690c87e3f020b6bd94aa6eda3d371

[danrubel, 2017-06-01 16:40:20]

danrubel@google.com changed reviewers:
+ ahe@google.com, scheglov@google.com

[scheglov, 2017-06-01 16:48:17]

LGTM

https://codereview.chromium.org/2915093002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/scanner/abstract_scanner.dart (right):

https://codereview.chromium.org/2915093002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/scanner/abstract_scanner.dart:166: * Appends a
substring from the scan offset [:start:] to the current
I have not seen using "[:X:]" anywhere recently.

[danrubel, 2017-06-01 17:25:42]

https://codereview.chromium.org/2915093002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/scanner/abstract_scanner.dart (right):

https://codereview.chromium.org/2915093002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/scanner/abstract_scanner.dart:166: * Appends a
substring from the scan offset [:start:] to the current
On 2017/06/01 16:48:17, scheglov wrote:
> I have not seen using "[:X:]" anywhere recently.

Whoops. Copy/paste bug from old style dartdoc. Fixed.

[ahe, 2017-06-02 12:26:44]

lgtm

https://codereview.chromium.org/2915093002/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/scanner/abstract_scanner.dart (right):

https://codereview.chromium.org/2915093002/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/scanner/abstract_scanner.dart:1238: int quoteChar,
int start, bool asciiOnlyString) {
Since these are for error handling, you could possibly collapse them into one
method with these named parameters:

{bool asciiOnlyString, bool isRaw, bool isMultiLine}

Normally, I avoid using names parameters in performance critical code, but this
isn't that.

https://codereview.chromium.org/2915093002/diff/20001/pkg/front_end/test/scan...
File pkg/front_end/test/scanner_test.dart (right):

https://codereview.chromium.org/2915093002/diff/20001/pkg/front_end/test/scan...
pkg/front_end/test/scanner_test.dart:998: // fasta inserts synthetic closers
fasta -> Fasta
Add period at end of sentence.

Here and several places below.

[danrubel, 2017-06-02 15:51:16]

Description was changed from

==========
improve fasta unterminated string recovery

This updates the fasta scanner
to append synthetic closing quotes to unterminated strings.

Rework of https://codereview.chromium.org/2912693002/
==========

to

==========
improve fasta unterminated string recovery

This updates the fasta scanner
to append synthetic closing quotes to unterminated strings.

Rework of https://codereview.chromium.org/2912693002/

R=ahe@google.com, scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b61f9f2343e690c87e3f020b6bd94aa6eda3d371
==========

[danrubel, 2017-06-02 15:51:18]

Committed patchset #2 (id:20001) manually as
b61f9f2343e690c87e3f020b6bd94aa6eda3d371 (presubmit successful).

[danrubel, 2017-06-07 15:51:41]

https://codereview.chromium.org/2915093002/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/scanner/abstract_scanner.dart (right):

https://codereview.chromium.org/2915093002/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/scanner/abstract_scanner.dart:1238: int quoteChar,
int start, bool asciiOnlyString) {
On 2017/06/02 12:26:43, ahe wrote:
> Since these are for error handling, you could possibly collapse them into one
> method with these named parameters:
> 
> {bool asciiOnlyString, bool isRaw, bool isMultiLine}
> 
> Normally, I avoid using names parameters in performance critical code, but
this
> isn't that.

Sounds reasonable. Fixed in https://codereview.chromium.org/2919163002/