Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 2941573002: cros: add google/mic icons to searchbox (Closed)

Created:
3 years, 6 months ago by Qiang(Joe) Xu
Modified:
3 years, 6 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, tfarina, Matt Giuca
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: add google/mic icons to searchbox Changes: (1) add ui/app_list/vector_icons to store new assets and apply them based on the state that wallpaper color customization is not available. (2) remove back button in searchbox for new launcher TODO: current searchbox background color, icon and hint text color are all defined assuming that wallpaper color customization is not available. Modify them when wallpaper color info is available. R=xiyuan@chromium.org BUG=731891 TEST=device test, with --enable-features=EnableFullscreenAppList flag, UI is in a correct WIP state. Without flag, it falls to current behavior. Review-Url: https://codereview.chromium.org/2941573002 Cr-Commit-Position: refs/heads/master@{#479196} Committed: https://chromium.googlesource.com/chromium/src/+/a7ab578dc05583c914b5a1c395df4f6163dbac6e

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 13

Patch Set 3 : another rebase #

Patch Set 4 : feedback #

Total comments: 2

Patch Set 5 : constexpr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+231 lines, -37 lines) Patch
M ui/app_list/BUILD.gn View 2 chunks +15 lines, -0 lines 0 comments Download
M ui/app_list/app_list_constants.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/app_list_constants.cc View 1 chunk +1 line, -1 line 0 comments Download
A ui/app_list/vector_icons/ic_google_black.icon View 1 chunk +20 lines, -0 lines 0 comments Download
A ui/app_list/vector_icons/ic_google_black.1x.icon View 1 chunk +21 lines, -0 lines 0 comments Download
A ui/app_list/vector_icons/ic_mic_black.icon View 1 chunk +24 lines, -0 lines 0 comments Download
A ui/app_list/vector_icons/ic_mic_black.1x.icon View 1 chunk +25 lines, -0 lines 0 comments Download
A ui/app_list/vector_icons/vector_icons.cc.template View 1 chunk +25 lines, -0 lines 0 comments Download
A ui/app_list/vector_icons/vector_icons.h.template View 1 chunk +26 lines, -0 lines 0 comments Download
M ui/app_list/views/contents_view.cc View 1 chunk +9 lines, -7 lines 0 comments Download
M ui/app_list/views/search_box_view.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M ui/app_list/views/search_box_view.cc View 1 2 3 4 8 chunks +61 lines, -27 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
Qiang(Joe) Xu
xiyuan PTAL thanks
3 years, 6 months ago (2017-06-13 19:01:39 UTC) #7
xiyuan
https://codereview.chromium.org/2941573002/diff/20001/ui/app_list/views/search_box_view.cc File ui/app_list/views/search_box_view.cc (right): https://codereview.chromium.org/2941573002/diff/20001/ui/app_list/views/search_box_view.cc#newcode64 ui/app_list/views/search_box_view.cc:64: SkColorSetA(SK_ColorTRANSPARENT, 0xDE); nit: SK_ColorTRANSPARENT -> SK_ColorBLACK. Techniquely, this is ...
3 years, 6 months ago (2017-06-13 20:10:41 UTC) #8
Qiang(Joe) Xu
comments addressed, ptal https://codereview.chromium.org/2941573002/diff/20001/ui/app_list/views/search_box_view.cc File ui/app_list/views/search_box_view.cc (right): https://codereview.chromium.org/2941573002/diff/20001/ui/app_list/views/search_box_view.cc#newcode64 ui/app_list/views/search_box_view.cc:64: SkColorSetA(SK_ColorTRANSPARENT, 0xDE); On 2017/06/13 20:10:41, xiyuan ...
3 years, 6 months ago (2017-06-13 20:50:53 UTC) #12
xiyuan
lgtm https://codereview.chromium.org/2941573002/diff/20001/ui/app_list/views/search_box_view.cc File ui/app_list/views/search_box_view.cc (right): https://codereview.chromium.org/2941573002/diff/20001/ui/app_list/views/search_box_view.cc#newcode452 ui/app_list/views/search_box_view.cc:452: kDefaultSearchboxColor)); On 2017/06/13 20:50:53, Qiang(Joe) Xu wrote: > ...
3 years, 6 months ago (2017-06-13 21:09:27 UTC) #13
Qiang(Joe) Xu
https://codereview.chromium.org/2941573002/diff/80001/ui/app_list/views/search_box_view.cc File ui/app_list/views/search_box_view.cc (right): https://codereview.chromium.org/2941573002/diff/80001/ui/app_list/views/search_box_view.cc#newcode47 ui/app_list/views/search_box_view.cc:47: const int kPadding = 16; On 2017/06/13 21:09:27, xiyuan ...
3 years, 6 months ago (2017-06-13 21:31:22 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2941573002/100001
3 years, 6 months ago (2017-06-13 21:32:08 UTC) #17
commit-bot: I haz the power
3 years, 6 months ago (2017-06-13 23:10:54 UTC) #20
Message was sent while issue was closed.
Committed patchset #5 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/a7ab578dc05583c914b5a1c395df...

Powered by Google App Engine
This is Rietveld 408576698