Reland "SelectSettings algorithm for audio constraints."

Reland "SelectSettings algorithm for audio constraints."

This is a reland of 51e98fac1dfdffcd0c04639bc60aedd97a272ae9
Original change's description:
> SelectSettings algorithm for audio constraints.
>
> This is intended to be used in getUserMedia to implement spec-compliant
> audio constraints processing.
>
> BUG=657733
>
> Change-Id: Ida1bc5561b16b0c5ac1628c19c71fb8f0b5a33fd
> Reviewed-on: https://chromium-review.googlesource.com/517782
> Commit-Queue: Guido Urdaneta <guidou@chromium.org>;
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>;
> Reviewed-by: Henrik Boström <hbos@chromium.org>;
> Cr-Commit-Position: refs/heads/master@{#478607}

BUG=657733
Review-Url: https://codereview.chromium.org/2941553003
Cr-Commit-Position: refs/heads/master@{#480445}
Committed: https://chromium.googlesource.com/chromium/src/+/4f7a4c8b074a1801729d351217b719fee1244b90

[Guido Urdaneta, 2017-06-13 18:08:53]

Description was changed from

==========
Reland "SelectSettings algorithm for audio constraints."

This is a reland of 51e98fac1dfdffcd0c04639bc60aedd97a272ae9
Original change's description:
> SelectSettings algorithm for audio constraints.
>
> This is intended to be used in getUserMedia to implement spec-compliant
> audio constraints processing.
>
> BUG=657733
>
> Change-Id: Ida1bc5561b16b0c5ac1628c19c71fb8f0b5a33fd
> Reviewed-on: https://chromium-review.googlesource.com/517782
> Commit-Queue: Guido Urdaneta <guidou@chromium.org>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Reviewed-by: Henrik Boström <hbos@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#478607}

BUG=657733
==========

to

==========
Reland "SelectSettings algorithm for audio constraints."

This is a reland of 51e98fac1dfdffcd0c04639bc60aedd97a272ae9
Original change's description:
> SelectSettings algorithm for audio constraints.
>
> This is intended to be used in getUserMedia to implement spec-compliant
> audio constraints processing.
>
> BUG=657733
>
> Change-Id: Ida1bc5561b16b0c5ac1628c19c71fb8f0b5a33fd
> Reviewed-on: https://chromium-review.googlesource.com/517782
> Commit-Queue: Guido Urdaneta <guidou@chromium.org>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Reviewed-by: Henrik Boström <hbos@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#478607}

BUG=657733
==========

[Guido Urdaneta, 2017-06-13 18:08:53]

guidou@chromium.org changed reviewers:
+ hbos@chromium.org

[Guido Urdaneta, 2017-06-13 18:12:18]

Hi, PTAL.

This is the exact same code that was originally landed.
It was reverted due to a test failing on the Windows Dbg bot.
I believe it was a compiler bug. 
This CL has a workaround that I believe works on all builds.

PS1 has the CL as originally landed.
PS2 has the workaround.

[Guido Urdaneta, 2017-06-13 18:18:26]

The CQ bit was checked by guidou@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 18:18:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 20:35:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 20:35:33]

Dry run: This issue passed the CQ dry run.

[hbos_chromium, 2017-06-14 08:12:12]

lgtm

https://codereview.chromium.org/2941553003/diff/20001/content/renderer/media/...
File content/renderer/media/media_stream_constraints_util_audio_unittest.cc
(right):

https://codereview.chromium.org/2941553003/diff/20001/content/renderer/media/...
content/renderer/media/media_stream_constraints_util_audio_unittest.cc:1258: //
Windows Debug build, making the test fail.
lol wtf

[Guido Urdaneta, 2017-06-14 08:23:12]

guidou@chromium.org changed reviewers:
+ jochen@chromium.org

[Guido Urdaneta, 2017-06-14 08:23:12]

jochen@chromium.org: can you rs this again?

[jochen (gone - plz use gerrit), 2017-06-19 12:59:52]

lgtm

[Guido Urdaneta, 2017-06-19 13:07:15]

The CQ bit was checked by guidou@chromium.org

[commit-bot: I haz the power, 2017-06-19 13:07:39]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-19 15:29:13]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497877635880430,
"parent_rev": "470096afdb28947722a3ecb946a4677f6ee9fa59", "commit_rev":
"4f7a4c8b074a1801729d351217b719fee1244b90"}

[commit-bot: I haz the power, 2017-06-19 15:29:23]

Description was changed from

==========
Reland "SelectSettings algorithm for audio constraints."

This is a reland of 51e98fac1dfdffcd0c04639bc60aedd97a272ae9
Original change's description:
> SelectSettings algorithm for audio constraints.
>
> This is intended to be used in getUserMedia to implement spec-compliant
> audio constraints processing.
>
> BUG=657733
>
> Change-Id: Ida1bc5561b16b0c5ac1628c19c71fb8f0b5a33fd
> Reviewed-on: https://chromium-review.googlesource.com/517782
> Commit-Queue: Guido Urdaneta <guidou@chromium.org>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Reviewed-by: Henrik Boström <hbos@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#478607}

BUG=657733
==========

to

==========
Reland "SelectSettings algorithm for audio constraints."

This is a reland of 51e98fac1dfdffcd0c04639bc60aedd97a272ae9
Original change's description:
> SelectSettings algorithm for audio constraints.
>
> This is intended to be used in getUserMedia to implement spec-compliant
> audio constraints processing.
>
> BUG=657733
>
> Change-Id: Ida1bc5561b16b0c5ac1628c19c71fb8f0b5a33fd
> Reviewed-on: https://chromium-review.googlesource.com/517782
> Commit-Queue: Guido Urdaneta <guidou@chromium.org>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Reviewed-by: Henrik Boström <hbos@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#478607}

BUG=657733

Review-Url: https://codereview.chromium.org/2941553003
Cr-Commit-Position: refs/heads/master@{#480445}
Committed:
https://chromium.googlesource.com/chromium/src/+/4f7a4c8b074a1801729d351217b7...
==========

[commit-bot: I haz the power, 2017-06-19 15:29:24]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4f7a4c8b074a1801729d351217b7...

[Reid Kleckner, 2017-06-23 00:01:46]

On 2017/06/19 15:29:24, commit-bot: I haz the power wrote:
> Committed patchset #2 (id:20001) as
>
https://chromium.googlesource.com/chromium/src/+/4f7a4c8b074a1801729d351217b7...

These new tests are failing on all Windows Clang DLL bots:
https://build.chromium.org/p/chromium.fyi/console?category=win%20clang
https://build.chromium.org/p/chromium.fyi/builders/ClangToTWin%28dll%29%20tes...