Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 2941473003: [heap] Retire V8_MAX_SEMISPACE_SIZE compile time flag. (Closed)

Created:
3 years, 6 months ago by Hannes Payer (out of office)
Modified:
3 years, 6 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office)
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Retire V8_MAX_SEMISPACE_SIZE compile time flag. Use the flags to configure the maximum semi-space size instead. BUG= Review-Url: https://codereview.chromium.org/2941473003 Cr-Commit-Position: refs/heads/master@{#45914} Committed: https://chromium.googlesource.com/v8/v8/+/ded5a1933eb726aff104766a4e57f06975c2b0be

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M src/heap/heap.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Hannes Payer (out of office)
3 years, 6 months ago (2017-06-13 13:16:34 UTC) #3
Michael Lippautz
lgtm
3 years, 6 months ago (2017-06-13 13:23:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2941473003/1
3 years, 6 months ago (2017-06-13 14:49:39 UTC) #6
commit-bot: I haz the power
3 years, 6 months ago (2017-06-13 15:28:42 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/ded5a1933eb726aff104766a4e57f06975c...

Powered by Google App Engine
This is Rietveld 408576698