Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2941453002: WebSocket frame masking: use SIMD for ARM (Closed)

Created:
3 years, 6 months ago by Adam Rice
Modified:
3 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

WebSocket frame masking: use SIMD for ARM WebSocket frame masking has been using SIMD on X86 for GCC and Clang for a while. Now that Chrome no longer supports disabling ARM Neon (SIMD) instructions at runtime, we can also perform the same optimisation for ARM. I have verified that this change causes a 128-bit vector XOR instruction to be used when compiling for ARM7, and a good-quality fallback when compiling for ARM6. BUG=539259 Review-Url: https://codereview.chromium.org/2941453002 Cr-Commit-Position: refs/heads/master@{#478966} Committed: https://chromium.googlesource.com/chromium/src/+/813f94f9d2cb7e696795053bc920276ff15d5ba4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M net/websockets/websocket_frame.cc View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Adam Rice
3 years, 6 months ago (2017-06-13 02:41:00 UTC) #3
tyoshino (SeeGerritForStatus)
lgtm
3 years, 6 months ago (2017-06-13 06:43:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2941453002/1
3 years, 6 months ago (2017-06-13 11:28:01 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-13 11:32:12 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/813f94f9d2cb7e696795053bc920...

Powered by Google App Engine
This is Rietveld 408576698