Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2941393002:
color: Force an sRGB color space for browser tests (Closed)
Descriptioncolor: Force an sRGB color space for browser tests
The results of these tests should not depend on the color profile of
the monitor that happens to be attached to the system. This flag
makes the tests ignore that profile and always use an sRGB color
profile (which is what the tests had been assuming all along).
BUG=734262
Review-Url: https://codereview.chromium.org/2941393002
Cr-Commit-Position: refs/heads/master@{#480741}
Committed: https://chromium.googlesource.com/chromium/src/+/bbb6768a4ba97d6222d0e5e7715435068e4fa2b3
Patch Set 1 #Patch Set 2 : Fix build #Patch Set 3 : Change to enable by default and try running #Patch Set 4 : Try just forcing profile #Patch Set 5 : Just the switch bit #Messages
Total messages: 25 (21 generated)
The CQ bit was checked by ccameron@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...) linux_chromium_headless_rel on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by ccameron@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by ccameron@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
Description was changed from ========== color: Enable color correct rendering for browser tests Also force the output color profile to be sRGB to enforce uniformity. BUG=734262 ========== to ========== color: Force an sRGB color space for browser tests The results of these tests should not depend on the color profile of the monitor that happens to be attached to the system. This flag makes the tests ignore that profile and always use an sRGB color profile (which is what the tests had been assuming all along). BUG=734262 ==========
ccameron@chromium.org changed reviewers: + sky@chromium.org
The CQ bit was checked by ccameron@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
ptal The motivation for this patch is that we want to enable the ColorCorrectRendering feature. When that feature is enabled, a bunch of tests (tab capture, mostly) fail, because the color profile of the test machine's monitor ends up affecting the rendering results. By forcing a color profile, we make these tests deterministic again (and test tryjobs to enable color correct rendering like the one in the N-1th patchset start passing ... these tests).
LGTM
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by ccameron@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1497933649669570,
"parent_rev": "5dbfdd403c8d9e95d8463b3aac4fb34e987dce62", "commit_rev":
"bbb6768a4ba97d6222d0e5e7715435068e4fa2b3"}
Message was sent while issue was closed.
Description was changed from ========== color: Force an sRGB color space for browser tests The results of these tests should not depend on the color profile of the monitor that happens to be attached to the system. This flag makes the tests ignore that profile and always use an sRGB color profile (which is what the tests had been assuming all along). BUG=734262 ========== to ========== color: Force an sRGB color space for browser tests The results of these tests should not depend on the color profile of the monitor that happens to be attached to the system. This flag makes the tests ignore that profile and always use an sRGB color profile (which is what the tests had been assuming all along). BUG=734262 Review-Url: https://codereview.chromium.org/2941393002 Cr-Commit-Position: refs/heads/master@{#480741} Committed: https://chromium.googlesource.com/chromium/src/+/bbb6768a4ba97d6222d0e5e77154... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/bbb6768a4ba97d6222d0e5e77154... |
