Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2941353002: Indexed DB: Use BindOnce / OnceCallback / OnceClosure where applicable (Closed)

Created:
3 years, 6 months ago by jsbell
Modified:
3 years, 6 months ago
Reviewers:
dmurph
CC:
chromium-reviews, jam, jsbell+idb_chromium.org, darin-cc_chromium.org, cmumford
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Indexed DB: Use BindOnce / OnceCallback / OnceClosure where applicable Within the Indexed DB back end code, use BindOnce when posting tasks and setting mojo pipe connection error handlers, and make transaction operations OnceCallbacks since they never execute twice. (The storage::QuotaClient API still requires the generic base::Bind for now even though the callbacks are logically Once.) BUG=714018 Review-Url: https://codereview.chromium.org/2941353002 Cr-Commit-Position: refs/heads/master@{#480917} Committed: https://chromium.googlesource.com/chromium/src/+/fd99b4a093a45f4252aca3a683333dcb0a7cb30f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+304 lines, -336 lines) Patch
M content/browser/indexed_db/cursor_impl.cc View 4 chunks +13 lines, -11 lines 0 comments Download
M content/browser/indexed_db/database_impl.cc View 15 chunks +71 lines, -69 lines 0 comments Download
M content/browser/indexed_db/indexed_db_active_blob_registry.cc View 2 chunks +5 lines, -11 lines 0 comments Download
M content/browser/indexed_db/indexed_db_backing_store.cc View 3 chunks +11 lines, -15 lines 0 comments Download
M content/browser/indexed_db/indexed_db_backing_store_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M content/browser/indexed_db/indexed_db_browsertest.cc View 8 chunks +26 lines, -28 lines 0 comments Download
M content/browser/indexed_db/indexed_db_callbacks.cc View 15 chunks +38 lines, -38 lines 0 comments Download
M content/browser/indexed_db/indexed_db_context_impl.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M content/browser/indexed_db/indexed_db_cursor.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M content/browser/indexed_db/indexed_db_database.cc View 18 chunks +35 lines, -55 lines 0 comments Download
M content/browser/indexed_db/indexed_db_database_callbacks.cc View 5 chunks +18 lines, -18 lines 0 comments Download
M content/browser/indexed_db/indexed_db_database_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_dispatcher_host.cc View 4 chunks +13 lines, -12 lines 0 comments Download
M content/browser/indexed_db/indexed_db_internals_ui.cc View 6 chunks +17 lines, -21 lines 0 comments Download
M content/browser/indexed_db/indexed_db_quota_client.cc View 2 chunks +10 lines, -8 lines 0 comments Download
M content/browser/indexed_db/indexed_db_transaction.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/indexed_db/indexed_db_transaction.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M content/browser/indexed_db/indexed_db_transaction_unittest.cc View 10 chunks +20 lines, -20 lines 0 comments Download
M content/browser/indexed_db/indexed_db_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
jsbell
dmurph@ - please take a look?
3 years, 6 months ago (2017-06-16 21:24:30 UTC) #4
dmurph
lgtm
3 years, 6 months ago (2017-06-20 17:59:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2941353002/1
3 years, 6 months ago (2017-06-20 18:31:07 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-20 19:55:29 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fd99b4a093a45f4252aca3a68333...

Powered by Google App Engine
This is Rietveld 408576698