Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3040)

Unified Diff: base/process/launch_fuchsia.cc

Issue 2941283002: fuchsia: Use new, qualified error names, disable old names. (Closed)
Patch Set: don have Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/process/kill_fuchsia.cc ('k') | base/process/process_fuchsia.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/process/launch_fuchsia.cc
diff --git a/base/process/launch_fuchsia.cc b/base/process/launch_fuchsia.cc
index 4ab969afa3853bb8c8fb1c9f23b9a4f5ff1b4dfd..21ab302fc30592bf829111f7d7a6a7398a230fbc 100644
--- a/base/process/launch_fuchsia.cc
+++ b/base/process/launch_fuchsia.cc
@@ -36,7 +36,7 @@ bool GetAppOutputInternal(const std::vector<std::string>& argv,
launchpad_clone_fd(lp, STDIN_FILENO, STDIN_FILENO);
int pipe_fd;
mx_status_t status = launchpad_add_pipe(lp, &pipe_fd, STDOUT_FILENO);
- if (status != NO_ERROR) {
+ if (status != MX_OK) {
LOG(ERROR) << "launchpad_add_pipe failed: " << status;
launchpad_destroy(lp);
return false;
@@ -50,7 +50,7 @@ bool GetAppOutputInternal(const std::vector<std::string>& argv,
mx_handle_t proc;
const char* errmsg;
status = launchpad_go(lp, &proc, &errmsg);
- if (status != NO_ERROR) {
+ if (status != MX_OK) {
LOG(ERROR) << "launchpad_go failed: " << errmsg << ", status=" << status;
return false;
}
@@ -121,7 +121,7 @@ Process LaunchProcess(const std::vector<std::string>& argv,
mx_handle_t proc;
const char* errmsg;
mx_status_t status = launchpad_go(lp, &proc, &errmsg);
- if (status != NO_ERROR) {
+ if (status != MX_OK) {
LOG(ERROR) << "launchpad_go failed: " << errmsg << ", status=" << status;
return Process();
}
« no previous file with comments | « base/process/kill_fuchsia.cc ('k') | base/process/process_fuchsia.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698