Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2941233002:
Refactor PreviousRootInlineBoxCandidatePosition() (Closed)
|
Created:
3 years, 6 months ago by yosin_UTC9 Modified:
3 years, 6 months ago CC:
blink-reviews, chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionRefactor PreviousRootInlineBoxCandidatePosition()
This patch changes |PreviousRootInlineBoxCandidatePosition()| to use for-loop
instead of while-loop with const variable for improving readability.
This is similar to the patch[1] which changes
|NextRootInlineBoxCandidatePosition()|.
[1] http://crrev.com/crrev.com/2936263004: Refactor
NextRootInlineBoxCandidatePosition()
BUG=n/a
TEST=n/a; no behavior changes
Review-Url: https://codereview.chromium.org/2941233002
Cr-Commit-Position: refs/heads/master@{#480346}
Committed: https://chromium.googlesource.com/chromium/src/+/38be868490ba34578d64c91e4eebdc44bef9b5cd
Patch Set 1 : 2017-06-16T17:14:24 #
Messages
Total messages: 20 (14 generated)
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== 2017-06-16T16:52:50 BUG= 2017-06-16T16:52:47 ========== to ========== Refactor PreviousRootInlineBoxCandidatePosition() This patch changes |PreviousRootInlineBoxCandidatePosition()| to use for-loop instead of while-loop with const variable for improving readability. This is similar to the patch[1] which changes |NextRootInlineBoxCandidatePosition()|. [1] http://crrev.com/crrev.com/2936263004: Refactor NextRootInlineBoxCandidatePosition() BUG=n/a TEST=n/a; no behavior changes ==========
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
Patchset #1 (id:1) has been deleted
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
yosin@chromium.org changed reviewers: + xiaochengh@chromium.org, yoichio@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
lgtm
The CQ bit was checked by yosin@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by yosin@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497837501997810,
"parent_rev": "e5ef406c5191bf506cb24a1c6306b135ea2732fa", "commit_rev":
"38be868490ba34578d64c91e4eebdc44bef9b5cd"}
Message was sent while issue was closed.
Description was changed from ========== Refactor PreviousRootInlineBoxCandidatePosition() This patch changes |PreviousRootInlineBoxCandidatePosition()| to use for-loop instead of while-loop with const variable for improving readability. This is similar to the patch[1] which changes |NextRootInlineBoxCandidatePosition()|. [1] http://crrev.com/crrev.com/2936263004: Refactor NextRootInlineBoxCandidatePosition() BUG=n/a TEST=n/a; no behavior changes ========== to ========== Refactor PreviousRootInlineBoxCandidatePosition() This patch changes |PreviousRootInlineBoxCandidatePosition()| to use for-loop instead of while-loop with const variable for improving readability. This is similar to the patch[1] which changes |NextRootInlineBoxCandidatePosition()|. [1] http://crrev.com/crrev.com/2936263004: Refactor NextRootInlineBoxCandidatePosition() BUG=n/a TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2941233002 Cr-Commit-Position: refs/heads/master@{#480346} Committed: https://chromium.googlesource.com/chromium/src/+/38be868490ba34578d64c91e4eeb... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as https://chromium.googlesource.com/chromium/src/+/38be868490ba34578d64c91e4eeb... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
