Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2941213002: Get rid of forward declaration of ComputeInlineBoxPositionForTextNode() (Closed)

Created:
3 years, 6 months ago by yosin_UTC9
Modified:
3 years, 6 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

2941213002: Get rid of forward declaration of ComputeInlineBoxPositionForTextNode() This patch moves implementation of |ComputeInlineBoxPositionForTextNode()| at forward declaration to get rid of forward declaration for improving code health. This is follow-up the patch[1] which inttroduces it. [1] http://crrev.com/2941013003 Introduce ComputeInlineBoxPositionForTextNode() BUG=707656 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2941213002 Cr-Commit-Position: refs/heads/master@{#479986} Committed: https://chromium.googlesource.com/chromium/src/+/f27177df9fa6d949bd33fd6095f8c8a1481b1890

Patch Set 1 : 2017-06-16T14:34:05 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -52 lines) Patch
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 2 chunks +43 lines, -52 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
yosin_UTC9
PTAL
3 years, 6 months ago (2017-06-16 06:43:22 UTC) #5
yoichio
lgtm
3 years, 6 months ago (2017-06-16 07:49:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2941213002/1
3 years, 6 months ago (2017-06-16 07:53:49 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-16 07:57:04 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f27177df9fa6d949bd33fd6095f8...

Powered by Google App Engine
This is Rietveld 408576698