Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 2941193002: Fix unique_ptr usage warning in bluetooth_task_manager_win.cc. (Closed)

Created:
3 years, 6 months ago by Bret
Modified:
3 years, 6 months ago
Reviewers:
scheib
CC:
chromium-reviews, scheib+watch_chromium.org, ortuno+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix unique_ptr usage warning in bluetooth_task_manager_win.cc. PVS-Studio gave this warning: device\bluetooth\bluetooth_task_manager_win.cc(880): warning V554: Incorrect use of unique_ptr. The memory allocated with 'new []' will be cleaned using 'delete'. BUG=697659 Review-Url: https://codereview.chromium.org/2941193002 Cr-Commit-Position: refs/heads/master@{#482025} Committed: https://chromium.googlesource.com/chromium/src/+/749ba3dbe97a100b5b09b6ce1d2829dd85b43c9d

Patch Set 1 #

Patch Set 2 : static_cast to reinterpret_cast #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M device/bluetooth/bluetooth_task_manager_win.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
Bret
3 years, 6 months ago (2017-06-22 01:23:15 UTC) #11
scheib
/me grumbles about windows BTH_LE_GATT_CHARACTERISTIC_VALUE LGTM
3 years, 6 months ago (2017-06-23 17:58:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2941193002/20001
3 years, 6 months ago (2017-06-23 18:54:38 UTC) #14
commit-bot: I haz the power
3 years, 6 months ago (2017-06-23 21:01:48 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/749ba3dbe97a100b5b09b6ce1d28...

Powered by Google App Engine
This is Rietveld 408576698