Prevent "Incompatible App" message when entering VR.

Prevent "Incompatible App" message when entering VR.

This CL adds VR manifest filters to convince Daydream that Chrome supports
VR, to avoid Daydream showing the Incompatible App message.

We can finally do this because the 1.6 Daydream SDK allows us to provide
our own VR entry intent and avoid getting stuck on the contoller pairing
screen. Brief backstory on why we need our own VR entry intent is because
CustomTab cannot be resumed via Daydreams normal intent - it needs to be a
BroadcastIntent.

This means we can also remove the launchInVr() code and simply try to enter
VR when requested and the GvrLayout will handle calling the DON flow.

BUG=717721
Review-Url: https://codereview.chromium.org/2941173002
Cr-Commit-Position: refs/heads/master@{#482638}
Committed: https://chromium.googlesource.com/chromium/src/+/eafc049ccec45550ea86089c463918131d04e927

[mthiesse, 2017-06-15 23:40:54]

mthiesse@chromium.org changed reviewers:
+ dtrainor@chromium.org, ymalik@chromium.org

[mthiesse, 2017-06-15 23:40:55]

dtrainor, please review AndroidManifest changes.
ymalik, please review vr_shell changes.

[ymalik, 2017-06-16 14:19:38]

https://codereview.chromium.org/2941173002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
(right):

https://codereview.chromium.org/2941173002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java:124:
setReentryIntent(VrShellDelegate.getEnterVrPendingIntent(activity));
Where is this function defined and what does it do?

[mthiesse, 2017-06-16 14:35:28]

https://codereview.chromium.org/2941173002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
(right):

https://codereview.chromium.org/2941173002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java:124:
setReentryIntent(VrShellDelegate.getEnterVrPendingIntent(activity));
On 2017/06/16 14:19:38, ymalik wrote:
> Where is this function defined and what does it do?

The documentation on it isn't visible because it's currently marked hidden
(Chrome is the first user of the API and they want to make sure it works well
for us and is useful before committing to long-term support). setReentryIntent
is a function on GvrLayout that lets us override the default PendingIntent they
create to re-launch your app after the DON flow, when the DON flow is triggered
by resuming the GvrLayout (which is the usual case for VR apps).

Check the internal source for more documentation.

[ymalik, 2017-06-16 14:41:06]

vr_shell lgtm

https://codereview.chromium.org/2941173002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
(right):

https://codereview.chromium.org/2941173002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java:124:
setReentryIntent(VrShellDelegate.getEnterVrPendingIntent(activity));
On 2017/06/16 14:35:28, mthiesse wrote:
> On 2017/06/16 14:19:38, ymalik wrote:
> > Where is this function defined and what does it do?
> 
> The documentation on it isn't visible because it's currently marked hidden
> (Chrome is the first user of the API and they want to make sure it works well
> for us and is useful before committing to long-term support). setReentryIntent
> is a function on GvrLayout that lets us override the default PendingIntent
they
> create to re-launch your app after the DON flow, when the DON flow is
triggered
> by resuming the GvrLayout (which is the usual case for VR apps).
> 
> Check the internal source for more documentation.

Ah got it. I'd add a comment here for clarity.

[mthiesse, 2017-06-20 13:28:22]

Ping dtrainor, PTAL.

https://codereview.chromium.org/2941173002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
(right):

https://codereview.chromium.org/2941173002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java:124:
setReentryIntent(VrShellDelegate.getEnterVrPendingIntent(activity));
On 2017/06/16 14:41:06, ymalik wrote:
> On 2017/06/16 14:35:28, mthiesse wrote:
> > On 2017/06/16 14:19:38, ymalik wrote:
> > > Where is this function defined and what does it do?
> > 
> > The documentation on it isn't visible because it's currently marked hidden
> > (Chrome is the first user of the API and they want to make sure it works
well
> > for us and is useful before committing to long-term support).
setReentryIntent
> > is a function on GvrLayout that lets us override the default PendingIntent
> they
> > create to re-launch your app after the DON flow, when the DON flow is
> triggered
> > by resuming the GvrLayout (which is the usual case for VR apps).
> > 
> > Check the internal source for more documentation.
> 
> Ah got it. I'd add a comment here for clarity. 

Done.

[David Trainor- moved to gerrit, 2017-06-23 06:20:27]

lgtm.  +tedchoc@ for fyi.  Sorry I missed this I've been using the new code
review tool and sometimes forget to still check this old one.

[mthiesse, 2017-06-23 22:16:37]

The CQ bit was checked by mthiesse@chromium.org

[mthiesse, 2017-06-23 22:16:37]

The patchset sent to the CQ was uploaded after l-g-t-m from ymalik@chromium.org
Link to the patchset: https://codereview.chromium.org/2941173002/#ps20001
(title: "Add comments")

[commit-bot: I haz the power, 2017-06-23 22:16:58]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-23 23:21:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-23 23:21:11]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[mthiesse, 2017-06-27 15:09:26]

The CQ bit was checked by mthiesse@chromium.org

[mthiesse, 2017-06-27 15:09:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org, ymalik@chromium.org
Link to the patchset: https://codereview.chromium.org/2941173002/#ps40001
(title: "Resolve findbugs issue.")

[commit-bot: I haz the power, 2017-06-27 15:09:40]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-27 15:55:28]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1498576166905160,
"parent_rev": "4c99a3bacc41ff9b2da5453edbeb008facbfa420", "commit_rev":
"eafc049ccec45550ea86089c463918131d04e927"}

[commit-bot: I haz the power, 2017-06-27 15:55:41]

Description was changed from

==========
Prevent "Incompatible App" message when entering VR.

This CL adds VR manifest filters to convince Daydream that Chrome supports
VR, to avoid Daydream showing the Incompatible App message.

We can finally do this because the 1.6 Daydream SDK allows us to provide
our own VR entry intent and avoid getting stuck on the contoller pairing
screen. Brief backstory on why we need our own VR entry intent is because
CustomTab cannot be resumed via Daydreams normal intent - it needs to be a
BroadcastIntent.

This means we can also remove the launchInVr() code and simply try to enter
VR when requested and the GvrLayout will handle calling the DON flow.

BUG=717721
==========

to

==========
Prevent "Incompatible App" message when entering VR.

This CL adds VR manifest filters to convince Daydream that Chrome supports
VR, to avoid Daydream showing the Incompatible App message.

We can finally do this because the 1.6 Daydream SDK allows us to provide
our own VR entry intent and avoid getting stuck on the contoller pairing
screen. Brief backstory on why we need our own VR entry intent is because
CustomTab cannot be resumed via Daydreams normal intent - it needs to be a
BroadcastIntent.

This means we can also remove the launchInVr() code and simply try to enter
VR when requested and the GvrLayout will handle calling the DON flow.

BUG=717721

Review-Url: https://codereview.chromium.org/2941173002
Cr-Commit-Position: refs/heads/master@{#482638}
Committed:
https://chromium.googlesource.com/chromium/src/+/eafc049ccec45550ea86089c4639...
==========

[commit-bot: I haz the power, 2017-06-27 15:55:43]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/eafc049ccec45550ea86089c4639...