[Android] Convert to DeviceUtils versions of WaitUntilFullyBooted and GetExternalStoragePath.

[Android] Convert to DeviceUtils versions of WaitUntilFullyBooted and GetExternalStoragePath.

BUG=267773
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272434

[jbudorick, 2014-05-20 21:25:01]

Not sure about the way I've implemented the wifi wait. The current
implementation uses a TF util and appears to be used only in downstream scripts.

[craigdh, 2014-05-21 22:25:00]

lgtm.

https://codereview.chromium.org/294113003/diff/40001/build/android/pylib/devi...
File build/android/pylib/device/decorators.py (right):

https://codereview.chromium.org/294113003/diff/40001/build/android/pylib/devi...
build/android/pylib/device/decorators.py:25: def _TimeoutRetryWrapper(f,
timeout_func, retries_func, pass_values=False):
docstring with description of parameters

https://codereview.chromium.org/294113003/diff/40001/build/android/pylib/devi...
File build/android/pylib/device/device_utils.py (right):

https://codereview.chromium.org/294113003/diff/40001/build/android/pylib/devi...
build/android/pylib/device/device_utils.py:171: '_default_timeout',
'_default_retries')
duplicated strings should be module level constants

https://codereview.chromium.org/294113003/diff/40001/build/android/pylib/devi...
build/android/pylib/device/device_utils.py:192: wifi_enabled = False
these five lines can be just two:

while 'Wi-Fi is enabled' not in self.old_interface.RunShellCommand('dumpsys
wifi'):
  time.sleep(0.1)

https://codereview.chromium.org/294113003/diff/40001/build/android/pylib/gtes...
File build/android/pylib/gtest/test_package_apk.py (right):

https://codereview.chromium.org/294113003/diff/40001/build/android/pylib/gtes...
build/android/pylib/gtest/test_package_apk.py:94: #                 conversions
are done.
just fyi, I think the style guide is agnostic about whether you line this up or
just wrap to the beginning of the line

[jbudorick, 2014-05-22 04:49:57]

https://codereview.chromium.org/294113003/diff/40001/build/android/pylib/devi...
File build/android/pylib/device/decorators.py (right):

https://codereview.chromium.org/294113003/diff/40001/build/android/pylib/devi...
build/android/pylib/device/decorators.py:25: def _TimeoutRetryWrapper(f,
timeout_func, retries_func, pass_values=False):
On 2014/05/21 22:25:00, craigdh wrote:
> docstring with description of parameters

Done.

https://codereview.chromium.org/294113003/diff/40001/build/android/pylib/devi...
File build/android/pylib/device/device_utils.py (right):

https://codereview.chromium.org/294113003/diff/40001/build/android/pylib/devi...
build/android/pylib/device/device_utils.py:171: '_default_timeout',
'_default_retries')
On 2014/05/21 22:25:00, craigdh wrote:
> duplicated strings should be module level constants

Wound up doing what you suggested on the last CL - defaulting to
'_default_timeout' and '_default_retries' in the decorator.

https://codereview.chromium.org/294113003/diff/40001/build/android/pylib/devi...
build/android/pylib/device/device_utils.py:192: wifi_enabled = False
On 2014/05/21 22:25:00, craigdh wrote:
> these five lines can be just two:
> 
> while 'Wi-Fi is enabled' not in self.old_interface.RunShellCommand('dumpsys
> wifi'):
>   time.sleep(0.1)

Done, though sadly it doesn't fit in 80 characters.

[jbudorick, 2014-05-22 16:55:46]

ptal. some changes to how DeviceUtils uses Parallelizer.

[craigdh, 2014-05-22 17:22:05]

lgtm with nits

https://codereview.chromium.org/294113003/diff/70001/build/android/pylib/devi...
File build/android/pylib/device/device_utils.py (right):

https://codereview.chromium.org/294113003/diff/70001/build/android/pylib/devi...
build/android/pylib/device/device_utils.py:178: if async:
parallelizer_type = parallelizer.Parallelizer if async else
parallelizer.SyncParallelizer

https://codereview.chromium.org/294113003/diff/70001/build/android/pylib/util...
File build/android/pylib/utils/test_environment.py (right):

https://codereview.chromium.org/294113003/diff/70001/build/android/pylib/util...
build/android/pylib/utils/test_environment.py:37: p =
device_utils.DeviceUtils.parallel(None)
the explicit passing of None here is a bit odd. I say either pass the list of
devices or call this without parameters to get all devices.

[jbudorick, 2014-05-22 19:26:39]

https://codereview.chromium.org/294113003/diff/70001/build/android/pylib/devi...
File build/android/pylib/device/device_utils.py (right):

https://codereview.chromium.org/294113003/diff/70001/build/android/pylib/devi...
build/android/pylib/device/device_utils.py:178: if async:
On 2014/05/22 17:22:05, craigdh wrote:
> parallelizer_type = parallelizer.Parallelizer if async else
> parallelizer.SyncParallelizer

Done.

https://codereview.chromium.org/294113003/diff/70001/build/android/pylib/util...
File build/android/pylib/utils/test_environment.py (right):

https://codereview.chromium.org/294113003/diff/70001/build/android/pylib/util...
build/android/pylib/utils/test_environment.py:37: p =
device_utils.DeviceUtils.parallel(None)
On 2014/05/22 17:22:05, craigdh wrote:
> the explicit passing of None here is a bit odd. I say either pass the list of
> devices or call this without parameters to get all devices.

Switched to calling without parameters + added support for doing so in
DeviceUtils.parallel.

[jbudorick, 2014-05-22 19:49:57]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2014-05-22 19:51:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jbudorick@chromium.org/294113003/80001

[commit-bot: I haz the power, 2014-05-22 23:03:48]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-23 01:23:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-23 01:23:50]

Try jobs failed on following builders:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[jbudorick, 2014-05-23 01:24:28]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2014-05-23 01:25:52]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jbudorick@chromium.org/294113003/80001

[commit-bot: I haz the power, 2014-05-23 07:46:22]

Change committed as 272434